Skip to content

Move personality implementation out of PAL #119935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Move personality implementation out of PAL #119935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb052d5
std: move personality implementation out of PAL
joboet Jan 13, 2024
b8d996c
tidy: allow platform-dependent code in `sys`
joboet Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions library/std/src/sys/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
/// descriptors.
mod pal;

mod personality;

// FIXME(117276): remove this, move feature implementations into individual
// submodules.
pub use pal::*;
1 change: 0 additions & 1 deletion library/std/src/sys/pal/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#![allow(missing_debug_implementations)]

pub mod common;
mod personality;

cfg_if::cfg_if! {
if #[cfg(unix)] {
Expand Down
0 ...y/std/src/sys/pal/personality/dwarf/eh.rs → library/std/src/sys/personality/dwarf/eh.rs
View file
Open in desktop
File renamed without changes.
0 .../std/src/sys/pal/personality/dwarf/mod.rs → library/std/src/sys/personality/dwarf/mod.rs
View file
Open in desktop
File renamed without changes.
0 ...td/src/sys/pal/personality/dwarf/tests.rs → ...ry/std/src/sys/personality/dwarf/tests.rs
View file
Open in desktop
File renamed without changes.
0 library/std/src/sys/pal/personality/emcc.rs → library/std/src/sys/personality/emcc.rs
View file
Open in desktop
File renamed without changes.
0 library/std/src/sys/pal/personality/gcc.rs → library/std/src/sys/personality/gcc.rs
View file
Open in desktop
File renamed without changes.
0 library/std/src/sys/pal/personality/mod.rs → library/std/src/sys/personality/mod.rs
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions src/tools/tidy/src/pal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ const EXCEPTION_PATHS: &[&str] = &[
// we must use `#[cfg(windows)]` to conditionally compile the
// correct `VaList` structure for windows.
"library/core/src/ffi/mod.rs",
"library/std/src/sys/pal/", // Platform-specific code for std lives here.
"library/std/src/os", // Platform-specific public interfaces
"library/std/src/sys", // Platform-specific code for std lives here.
"library/std/src/os", // Platform-specific public interfaces
// Temporary `std` exceptions
// FIXME: platform-specific code should be moved to `sys`
"library/std/src/io/copy.rs",
Expand Down