portable-simd: fix test suite build #118591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
|
Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead. |
rustbot
added
the
S-waiting-on-review
|
We do not run the proptest-driven suite in Rust CI because so far I have not heard anyone speak in favor of adding more nondeterminism to the test suite, for some mysterious reason, and many have spoken against. |
|
Might be worth to have it covered by |
|
That seems reasonable. |
calebzulawski
approved these changes
Dec 4, 2023
|
@bors r=workingjubilee,calebzulawski rollup |
|
🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 4, 2023
…r=workingjubilee,calebzulawski portable-simd: fix test suite build `@workingjubilee` `@calebzulawski` don't we run these portable-simd tests on rustc CI? Currently they don't even build here.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118076 (Tweak `.clone()` suggestion to work in more cases) - rust-lang#118508 (rustdoc: do not escape quotes in body text) - rust-lang#118565 (interpret: make numeric_intrinsic accessible from Miri) - rust-lang#118591 (portable-simd: fix test suite build) - rust-lang#118600 ([rustdoc] Don't generate the "Fields" heading if there is no field displayed) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2023
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#118508 (rustdoc: do not escape quotes in body text) - rust-lang#118565 (interpret: make numeric_intrinsic accessible from Miri) - rust-lang#118591 (portable-simd: fix test suite build) - rust-lang#118600 ([rustdoc] Don't generate the "Fields" heading if there is no field displayed) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2023
Rollup merge of rust-lang#118591 - RalfJung:portable-simd-build-fix, r=workingjubilee,calebzulawski portable-simd: fix test suite build ``@workingjubilee`` ``@calebzulawski`` don't we run these portable-simd tests on rustc CI? Currently they don't even build here.
workingjubilee
added
A-SIMD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@workingjubilee @calebzulawski don't we run these portable-simd tests on rustc CI? Currently they don't even build here.