Skip to content

Conversation

compiler-errors
Copy link
Member

We don't necessarily have a receiver when we are both accidentally using the . operator AND we have more than one ambiguous method candidate.

Fixes #117728

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2023
@rust-log-analyzer

This comment has been minimized.

@compiler-errors compiler-errors force-pushed the method-ambiguity-no-rcvr branch from 99a09b2 to 0dfa9eb Compare November 12, 2023 19:56
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@compiler-errors compiler-errors force-pushed the method-ambiguity-no-rcvr branch from 0dfa9eb to 99664b0 Compare November 12, 2023 19:59
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Nov 15, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 15, 2023

📌 Commit 99664b0 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2023
@bors
Copy link
Collaborator

bors commented Nov 15, 2023

⌛ Testing commit 99664b0 with merge 383bf02...

@bors
Copy link
Collaborator

bors commented Nov 15, 2023

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 383bf02 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2023
@bors bors merged commit 383bf02 into rust-lang:master Nov 15, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (383bf02): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [3.8%, 3.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.537s -> 673.093s (-0.36%)
Artifact size: 311.09 MiB -> 311.10 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ice: OOB in diagnostic
6 participants