Update Clippy #115790

flip1995 · 2023-09-12T16:14:35Z

Co-authored-by: Nahua <[email protected]>

…bal vars

…ss_borrow`

[`iter_overeager_cloned`]: detect .cloned().all() and .cloned().any() changelog: [`iter_overeager_cloned`] r? `@blyxyas`

allow trait alias DefIds in `implements_trait_with_env_from_iter` Fixes rust-lang#11337 changelog: none

[`arithmetic_side_effects`] Fix rust-lang#11393 Fix rust-lang#11393 ``` changelog: [`arithmetic_side_effects`]: Detect division by zero for `Wrapping` and `Saturating` ```

and narrow search span when const/static items are in a mod block

bors · 2023-09-12T16:17:45Z

⌛ Testing commit 2bd6936 with merge efc1a0a...

Update Clippy r? `@Manishearth`

Alexendoo · 2023-09-12T16:19:41Z

@bors r-

there are some dbg!s here https://github.com/rust-lang/rust/pull/115790/files/2bd69368a676467dbaf29920696bdcfc237072ce#diff-851f8155a62c6fd58266f64a27725aaeb2ac47dee3315b3df83a65cf033cc56bR102

flip1995 · 2023-09-12T16:23:57Z

@Alexendoo great catch. Those slipped through while debugging the ICE I fixed in this PR. I removed them

flip1995 · 2023-09-12T16:33:58Z

@bors r+

bors · 2023-09-12T16:34:00Z

📌 Commit d18c0c5 has been approved by flip1995

It is now in the queue for this repository.

bors · 2023-09-12T16:34:10Z

⌛ Testing commit d18c0c5 with merge b16b5fc...

Update Clippy r? `@Manishearth`

rust-log-analyzer · 2023-09-12T16:57:45Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests/ui-toml/absolute_paths/absolute_paths.rs (disallow_crates) ... ok
tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.rs ... ok

tests/ui-toml/disallowed_macros/disallowed_macros.rs FAILED:
command: CLIPPY_CONF_DIR="tests/ui-toml/disallowed_macros" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "--extern=clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-f6e1eb189b211467.rlib" "--extern=clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-75959e315c9ff2fe.rlib" "--extern=derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-cf1fe18d496b0b3a.so" "--extern=futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-ff96843d80cd8d4a.rlib" "--extern=if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-08c5e3ddca11c9d5.rlib" "--extern=itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-9aed67eaa870cd55.rlib" "--extern=parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-0d09972064e7da7b.rlib" "--extern=quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-5afd1bb919dc4480.rlib" "--extern=regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-5aefc6c5bb8b6fc1.rlib" "--extern=serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-9a3b80bce0dc30d0.rlib" "--extern=serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-a7b2e5101e0f873f.so" "--extern=syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-7a72a9ecddcd16d5.rlib" "--extern=tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-b072c5f1d078f0c8.rlib" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test" "tests/ui-toml/disallowed_macros/disallowed_macros.rs" "--edition" "2021" "--extern" "macros=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/tests/ui-toml/disallowed_macros/auxiliary/libmacros.rlib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/tests/ui-toml/disallowed_macros/auxiliary"
actual output differed from expected
actual output differed from expected
Execute `cargo uibless` to update `tests/ui-toml/disallowed_macros/disallowed_macros.stderr` to the actual output
--- tests/ui-toml/disallowed_macros/disallowed_macros.stderr
thread 'main' panicked at src/tools/clippy/tests/compile-test.rs:249:6:
called `Result::unwrap()` on an `Err` value: tests failed

Location:
---
   |
LL |     println!("one");
   |     ^^^^^^^^^^^^^^^
   |
   = note: `-D clippy::disallowed-macros` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::disallowed_macros)]`
error: use of a disallowed macro `std::println`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:11:5
   |
   |
LL |     println!("two");

error: use of a disallowed macro `std::cfg`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:12:5
   |
   |
LL |     cfg!(unix);
   |     ^^^^^^^^^^

error: use of a disallowed macro `std::vec`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:13:5
   |
LL |     vec![1, 2, 3];

error: use of a disallowed macro `serde::Serialize`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:15:14
   |
---

error: use of a disallowed macro `macros::expr`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:18:13
   |
LL |     let _ = macros::expr!();

error: use of a disallowed macro `macros::stmt`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:19:5
   |
   |
LL |     macros::stmt!();

error: use of a disallowed macro `macros::pat`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:20:9
   |
   |
LL |     let macros::pat!() = 1;
   |         ^^^^^^^^^^^^^^

error: use of a disallowed macro `macros::ty`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:21:12
   |
LL |     let _: macros::ty!() = "";

error: use of a disallowed macro `macros::item`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:22:5
   |
   |
LL |     macros::item!();
   |     ^^^^^^^^^^^^^^^

error: use of a disallowed macro `macros::binop`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:23:13
   |
LL |     let _ = macros::binop!(1);

error: use of a disallowed macro `macros::attr`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:28:1
   |

flip1995 · 2023-09-13T17:58:44Z

@bors r=Manishearth

Forgot to re-r+ this.

bors · 2023-09-13T17:58:46Z

📌 Commit 780cbf3 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2023-09-13T20:28:06Z

⌛ Testing commit 780cbf3 with merge 8142a31...

bors · 2023-09-13T22:21:20Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 8142a31 to master...

rust-timer · 2023-09-14T04:38:22Z

Finished benchmarking commit (8142a31): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.211s -> 631.556s (0.05%)
Artifact size: 317.91 MiB -> 317.95 MiB (0.01%)

Update Clippy r? `@Manishearth`

blyxyas and others added 30 commits April 17, 2023 10:24

New chapter: Emitting lints

f76615a

Don't pass extra generic arguments in needless_borrow

8277e7d

allow trait alias DefIds in implements_trait_with_env_from_iter

f746e19

Add new chapter: "Trait Checking"

3c50a0a

Fixes based on reviews

94387ef

Change Tokio example description to Core

b2e1ede

Fix CI

2a3f75b

New chapter: Writing tests

289bafa

Co-authored-by: Nahua <[email protected]>

Formatting, slimming and ui-toml tests

864df49

Applying review suggestions

32dc7c5

Formatting and minor wording fixes

9b8b835

Update rustfix section to new ui-test crate

8ee6ca0

fix [undocumented_unsafe_blocks] not able to detect comment for glo…

7721567

…bal vars

Fix span when linting explicit_auto_deref immediately after `needle…

82f2e52

…ss_borrow`

[unnecessary_unwrap]: lint on .as_ref().unwrap()

42c6492

[iter_overeager_cloned]: detect .cloned().all() and .cloned().any()

fb6fad2

when terminating during unwinding, show the reason why

70f6321

[arithmetic_side_effects] Fix rust-lang#11393

2faa43c

Dogfood

d802ab2

new lint: iter_out_of_bounds

86b6644

Merge commit '080b587854a73f2a8cbaecff1884860a78e2ff37' into clippyup

cc61aee

Auto merge of rust-lang#11360 - lengyijun:any_all, r=blyxyas

d65c459

[`iter_overeager_cloned`]: detect .cloned().all() and .cloned().any() changelog: [`iter_overeager_cloned`] r? `@blyxyas`

[if_then_some_else_none]: look into local initializers

dba7763

Auto merge of rust-lang#11338 - y21:issue11337, r=Centri3

19eaafb

allow trait alias DefIds in `implements_trait_with_env_from_iter` Fixes rust-lang#11337 changelog: none

lint vecs, version bump, more tests

11072b5

Auto merge of rust-lang#11395 - c410-f3r:let-chain, r=Manishearth

706c48b

[`arithmetic_side_effects`] Fix rust-lang#11393 Fix rust-lang#11393 ``` changelog: [`arithmetic_side_effects`]: Detect division by zero for `Wrapping` and `Saturating` ```

remove unecessary code

6eec4a3

and narrow search span when const/static items are in a mod block

fix "derivable_impls: attributes are ignored"

90fcc67

allow float_cmp when lhs is a custom type

e43c234

Remove redundant auxiliary test files

d78d26a

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2023

Auto merge of rust-lang#115790 - flip1995:clippyup, r=Manishearth

efc1a0a

Update Clippy r? `@Manishearth`

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2023

flip1995 force-pushed the clippyup branch from 2bd6936 to d18c0c5 Compare September 12, 2023 16:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 12, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2023

Auto merge of rust-lang#115790 - flip1995:clippyup, r=flip1995

b16b5fc

Update Clippy r? `@Manishearth`

This comment has been minimized.

Sign in to view

flip1995 added 2 commits September 12, 2023 18:44

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

9ff2e4e

Update Cargo.lock (ui_test update)

780cbf3

flip1995 force-pushed the clippyup branch from d18c0c5 to 780cbf3 Compare September 12, 2023 16:44

Alexendoo mentioned this pull request Sep 13, 2023

Update Rust toolchain version? rust-lang/rust-clippy#11490

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 13, 2023

bors merged commit 8142a31 into rust-lang:master Sep 13, 2023

rustbot added this to the 1.74.0 milestone Sep 13, 2023

bors mentioned this pull request Sep 13, 2023

Weekly cargo update #112865

Merged

Centri3 mentioned this pull request Sep 21, 2023

Fix mutaby used async function argument in closure for needless_pass_by_ref_mut rust-lang/rust-clippy#11492

Merged

flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 25, 2023

Auto merge of rust-lang#115790 - flip1995:clippyup, r=Manishearth

0698591

Update Clippy r? `@Manishearth`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Clippy #115790

Update Clippy #115790

Uh oh!

flip1995 commented Sep 12, 2023

Uh oh!

bors commented Sep 12, 2023

Uh oh!

Alexendoo commented Sep 12, 2023

Uh oh!

flip1995 commented Sep 12, 2023

Uh oh!

flip1995 commented Sep 12, 2023

Uh oh!

bors commented Sep 12, 2023

Uh oh!

bors commented Sep 12, 2023

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 12, 2023

Uh oh!

flip1995 commented Sep 13, 2023

Uh oh!

bors commented Sep 13, 2023

Uh oh!

bors commented Sep 13, 2023

Uh oh!

bors commented Sep 13, 2023

Uh oh!

rust-timer commented Sep 14, 2023

Uh oh!

Uh oh!

Update Clippy #115790

Update Clippy #115790

Uh oh!

Conversation

flip1995 commented Sep 12, 2023

Uh oh!

bors commented Sep 12, 2023

Uh oh!

Alexendoo commented Sep 12, 2023

Uh oh!

flip1995 commented Sep 12, 2023

Uh oh!

flip1995 commented Sep 12, 2023

Uh oh!

bors commented Sep 12, 2023

Uh oh!

bors commented Sep 12, 2023

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 12, 2023

Uh oh!

flip1995 commented Sep 13, 2023

Uh oh!

bors commented Sep 13, 2023

Uh oh!

bors commented Sep 13, 2023

Uh oh!

bors commented Sep 13, 2023

Uh oh!

rust-timer commented Sep 14, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!