Skip to content

Conversation

djkoloski
Copy link
Contributor

Updates the in-tree LLVM submodule to the 17.0.0-rc4 branch from rust-lang/llvm-project#151.

@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2023
@cuviper
Copy link
Member

cuviper commented Sep 5, 2023

Thanks!

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Sep 5, 2023

📌 Commit fba61a8 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2023
@bors
Copy link
Collaborator

bors commented Sep 5, 2023

⌛ Testing commit fba61a8 with merge ff902ff...

@bors
Copy link
Collaborator

bors commented Sep 6, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing ff902ff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 6, 2023
@bors bors merged commit ff902ff into rust-lang:master Sep 6, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 6, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ff902ff): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.337s -> 628.364s (0.00%)
Artifact size: 316.11 MiB -> 316.22 MiB (0.03%)

@wesleywiser wesleywiser added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 7, 2023
@wesleywiser
Copy link
Member

Nominating for beta backport to resolve the regression-from-stable-to-beta in #115385

@cuviper cuviper added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 19, 2023
@cuviper cuviper mentioned this pull request Sep 19, 2023
@wesleywiser wesleywiser removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2023
@wesleywiser
Copy link
Member

This was done via #115959 which has been accepted for beta backport.

@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants