Clarify cryptic comments #115578
Merged
Clarify cryptic comments #115578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Comment on lines
3
to
8
| // As a special exemption, `impl Drop` in the return position raises no error. | ||
| // This allows a convenient way to return an unnamed drop guard. | ||
| // Voldemort here refers to types that are unnameable. | ||
| fn voldemort_type() -> impl Drop { | ||
| struct Voldemort; | ||
| impl Drop for Voldemort { |
There was a problem hiding this comment.
Suggested change
| // As a special exemption, `impl Drop` in the return position raises no error. | |
| // This allows a convenient way to return an unnamed drop guard. | |
| // Voldemort here refers to types that are unnameable. | |
| fn voldemort_type() -> impl Drop { | |
| struct Voldemort; | |
| impl Drop for Voldemort { | |
| // As a special exemption, `impl Drop` in the return position raises no error. | |
| // This allows a convenient way to return an unnamed drop guard. | |
| fn unnameable_type() -> impl Drop { | |
| struct Unnameable; | |
| impl Drop for Unnameable { |
There was a problem hiding this comment.
(and the call right below, but i can't suggest changes on that part of the file 😸)
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Sep 6, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Sep 6, 2023
Clarify cryptic comments Clarifies some unclear comments that lurked in the compiler. r? `@oli-obk`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#114511 (Remove the unhelpful let binding diag comes from FormatArguments) - rust-lang#115473 (Add explanatory note to 'expected item' error) - rust-lang#115574 (Replace `rustc_data_structures` dependency with `rustc_index` in `rustc_parse_format`) - rust-lang#115578 (Clarify cryptic comments) - rust-lang#115587 (fix rust-lang#115348) - rust-lang#115596 (A small change) - rust-lang#115598 (Fix log formatting in bootstrap) - rust-lang#115605 (Better Debug for `Ty` in smir) - rust-lang#115614 (Fix minor grammar typo) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies some unclear comments that lurked in the compiler.
r? @oli-obk