also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set #115471

RalfJung · 2023-09-02T08:25:17Z

Currently I cannot test musl targets in Miri via x.py; this PR fixes that.

rustbot · 2023-09-02T08:25:22Z

r? @onur-ozkan

(rustbot has picked a reviewer for you, use r? to override)

onur-ozkan · 2023-09-02T08:28:24Z

Will queue it up once the CI is green

onur-ozkan · 2023-09-02T09:20:43Z

@bors r+

bors · 2023-09-02T09:20:45Z

📌 Commit 9cae47e has been approved by onur-ozkan

It is now in the queue for this repository.

bors · 2023-09-02T14:25:53Z

⌛ Testing commit 9cae47e with merge 1cabd455938f7d2a7ea85f2a824a4d04efb0704f...

rust-log-analyzer · 2023-09-02T14:35:20Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[00:18] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:18] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:18] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:18] / 
---
[00:18] / 
[ERROR]  >>

[00:18] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[00:18] / 
[00:18] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[00:18] / 
[00:18] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[00:18] / 
[00:18] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[00:18] / 
[00:18] / 
[ERROR]  >> preferably, a fix.
[00:18] / 
[ERROR]  >>

[00:18] / 
---
[00:27] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:27] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:27] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:27] / 
---
[00:27] / 
[ERROR]  >>

[00:27] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[00:27] / 
[00:27] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[00:27] / 
[00:27] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[00:27] / 
[00:27] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[00:27] / 
[00:27] / 
[ERROR]  >> preferably, a fix.
[00:27] / 
[ERROR]  >>

[00:27] / 
---
[01:22] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:22] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:22] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:22] / 
---
[01:22] / 
[ERROR]  >>

[01:22] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[01:22] / 
[01:22] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[01:22] / 
[01:22] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[01:22] / 
[01:22] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[01:22] / 
[01:22] / 
[ERROR]  >> preferably, a fix.
[01:22] / 
[ERROR]  >>

[01:22] / 
---
[01:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:19] / 
---
[01:19] / 
[ERROR]  >>

[01:19] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[01:19] / 
[01:19] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[01:19] / 
[01:19] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[01:19] / 
[01:19] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[01:19] / 
[01:19] / 
[ERROR]  >> preferably, a fix.
[01:19] / 
[ERROR]  >>

[01:19] / 
---
[01:20] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:20] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:20] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:20] / 
---
[01:20] / 
[ERROR]  >>

[01:20] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[01:20] / 
[01:20] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[01:20] / 
[01:20] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[01:20] / 
[01:20] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[01:20] / 
[01:20] / 
[ERROR]  >> preferably, a fix.
[01:20] / 
[ERROR]  >>

[01:20] /

bors · 2023-09-02T14:35:54Z

💔 Test failed - checks-actions

RalfJung · 2023-09-02T14:41:13Z

@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

bors · 2023-09-02T14:45:40Z

⌛ Testing commit 9cae47e with merge bd7ee1d72149a4f9a41d0dc1e0fbf25bbf0ea14b...

bors · 2023-09-02T14:53:29Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-09-02T14:55:42Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[00:20] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:20] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:20] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:20] / 
---
[00:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:19] / 
---
[01:16] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:16] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:16] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:16] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] /

RalfJung · 2023-09-02T15:06:53Z

@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

Mark-Simulacrum · 2023-09-02T20:14:32Z

@bors p=105

Trying to see if this works now...

bors · 2023-09-02T20:14:40Z

⌛ Testing commit 9cae47e with merge 9f5fc1b...

bors · 2023-09-02T22:00:17Z

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 9f5fc1b to master...

Mark-Simulacrum · 2023-09-02T22:11:56Z

@bors treeclosed-

rust-timer · 2023-09-03T08:04:03Z

Finished benchmarking commit (9f5fc1b): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[1.2%, 4.9%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	3.1%	[1.2%, 4.9%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.451s -> 630.462s (0.16%)
Artifact size: 316.50 MiB -> 316.63 MiB (0.04%)

also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set

9cae47e

rustbot assigned onur-ozkan Sep 2, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 2, 2023

onur-ozkan approved these changes Sep 2, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2023

bors merged commit 9f5fc1b into rust-lang:master Sep 2, 2023

rustbot added this to the 1.74.0 milestone Sep 2, 2023

RalfJung deleted the skipping-sanity branch September 3, 2023 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set #115471

also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set #115471

RalfJung commented Sep 2, 2023

rustbot commented Sep 2, 2023

onur-ozkan commented Sep 2, 2023

onur-ozkan commented Sep 2, 2023

bors commented Sep 2, 2023

bors commented Sep 2, 2023

rust-log-analyzer commented Sep 2, 2023

bors commented Sep 2, 2023

RalfJung commented Sep 2, 2023

bors commented Sep 2, 2023

bors commented Sep 2, 2023

rust-log-analyzer commented Sep 2, 2023

RalfJung commented Sep 2, 2023

Mark-Simulacrum commented Sep 2, 2023

bors commented Sep 2, 2023

bors commented Sep 2, 2023

Mark-Simulacrum commented Sep 2, 2023

rust-timer commented Sep 3, 2023

also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set #115471

also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set #115471

Conversation

RalfJung commented Sep 2, 2023

rustbot commented Sep 2, 2023

onur-ozkan commented Sep 2, 2023

onur-ozkan commented Sep 2, 2023

bors commented Sep 2, 2023

bors commented Sep 2, 2023

rust-log-analyzer commented Sep 2, 2023

bors commented Sep 2, 2023

RalfJung commented Sep 2, 2023

bors commented Sep 2, 2023

bors commented Sep 2, 2023

rust-log-analyzer commented Sep 2, 2023

RalfJung commented Sep 2, 2023

Mark-Simulacrum commented Sep 2, 2023

bors commented Sep 2, 2023

bors commented Sep 2, 2023

Mark-Simulacrum commented Sep 2, 2023

rust-timer commented Sep 3, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size