Load include_bytes! directly into an Lrc

[saethlin]

This PR deletes an innocent-looking .into() that was converting from a Vec<u8> to Lrc<[u8]>. This has significant runtime and memory overhead when using include_bytes! to pull in a large binary file.

[rustbot]

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

[jackh726]

@bors r+

[bors]

📌 Commit f26293d has been approved by jackh726

It is now in the queue for this repository.

[saethlin]

Based on searching the benchmark suite I suspect this won't have any observable perf impact, but the point is to make things faster...

@bors rollup=iffy

[bors]

⌛ Testing commit f26293d with merge 41cb42a...

[bors]

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 41cb42a to master...

[rust-timer]

Finished benchmarking commit (41cb42a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.6%, 3.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.3%, -2.0%]	2
All ❌✅ (primary)	3.6%	[3.6%, 3.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.239s -> 631.418s (-0.13%)
Artifact size: 316.22 MiB -> 316.30 MiB (0.03%)