Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ehuss and others added 10 commits June 17, 2023 17:20
…r=jsha

rustdoc: Fixes with --test-run-directory and relative paths.

Fixes rust-lang#112191
Fixes rust-lang#112210

This fixes some issues with `--test-run-directory` and its interaction with `--runtool` and `--persist-doctests`. Relative directories don't work with `Command::current_dir` very well because it has platform-specific behavior with relative paths. This fixes it by avoiding the use of relative paths.

This is needed because cargo is switching to use `--test-run-directory`, and it uses relative paths when interacting with rustdoc/rustc.
Update `mpsc::Sender` doc to reflect that it implements `Sync`

Fixes rust-lang#114722
clarify CStr lack of layout guarnatees

Follow-up to rust-lang#114800
r? `@cuviper`
…rors

Remove Folyd from librustdoc static files

r?`@GuillaumeGomez`
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 17, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Aug 17, 2023

📌 Commit 40edd35 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023
@bors
Copy link
Collaborator

bors commented Aug 17, 2023

⌛ Testing commit 40edd35 with merge d4a881e...

@bors
Copy link
Collaborator

bors commented Aug 17, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d4a881e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2023
@bors bors merged commit d4a881e into rust-lang:master Aug 17, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 17, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#112751 rustdoc: Fixes with --test-run-directory and relative paths. 6c4c18235cb524bcb690dbc4b46af3ee914e2054 (link)
#114749 Update mpsc::Sender doc to reflect that it implements `Sy… d5ed0cc5f7abce6b2c5d24f756c6921bcc07f2d8 (link)
#114876 Don't ICE in is_trivially_sized when encountering late-bo… 280d8f31dbd10e8dc2559f075b90dc8951f39f7e (link)
#114881 clarify CStr lack of layout guarnatees 9419f3ecb1be81287bd375edd310e1ba927cc58b (link)
#114921 Remove Folyd from librustdoc static files c58f6d9c9cfae4590b50ade3c97f4c8a2a7d5c62 (link)

previous master: aa864a7622

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d4a881e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)
1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.6%, 2.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.832s -> 634.954s (0.02%)
Artifact size: 347.01 MiB -> 347.10 MiB (0.03%)

@matthiaskrgr matthiaskrgr deleted the rollup-qktdihi branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants