Normalize return type of deduce_future_output_from_obligations
#114914
Conversation
rustbot
added
S-waiting-on-review
| "async fn generator return type not an inference variable: {ret_ty}" | ||
| ), | ||
| }; | ||
|
|
||
| let output_ty = self.normalize(span, output_ty); |
There was a problem hiding this comment.
can you move the normalize call into the ty::Alias branch? for infer vars the obligation should already be normalized
There was a problem hiding this comment.
That's the alias that corresponds to the impl Future. The type we want to normalize here is the Output of that future, which depends on what we extract out of get_future_output.
There was a problem hiding this comment.
Wait, wait, I think I understand here.
There was a problem hiding this comment.
Actually, we still may have unnormalized obligations for infer vars as well. The obligations returned from replace_opaque_with_infer and handle_opaque_ty are not normalized.
lcnr
added
S-waiting-on-author
|
@bors r=lcnr |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (39e0749): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 635.452s -> 636.001s (0.09%) |
Fixes #114909
Also confirmed to fix #114727 manually
Now that we have weak/lazy type aliases, we need to normalize those in future signatures to ensure that
replace_opaque_types_with_inference_varsactually sees TAITs behind them. This isn't needed in the new solver, but added a test to make sure it doesn't regress there either.r? types cc @oli-obk (who's gone, worst case can delay this PR until he's back)