Skip to content

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Aug 14, 2023

Found this while browsing rustc, I traced it back to #27893 when MIR first introduced, some time passed since then and I think this FIXME is no longer necessary.

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2023
@lcnr
Copy link
Contributor

lcnr commented Aug 14, 2023

r? @lcnr

@bors r+ rollup

@rustbot rustbot assigned lcnr and unassigned jackh726 Aug 14, 2023
@bors
Copy link
Collaborator

bors commented Aug 14, 2023

📌 Commit dcf2056 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#114745 (Make Const more useful in smir)
 - rust-lang#114752 (fixed *const [type error] does not implement the Copy trait)
 - rust-lang#114760 (DebugInfo: Updates test cases that add method declarations.)
 - rust-lang#114815 (Update books)
 - rust-lang#114817 (Remove unnecessary FIXME)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f0c17f into rust-lang:master Aug 14, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants