Update Clippy #114729

flip1995 · 2023-08-11T12:07:18Z

cc @Centri3 This reinstates the filter_map_bool_then lint #114715, since I think you fixed the ICE in beb57f0 which is included in this sync.

This is necessary for closure captures in 2021 edition, as they capture individual fields, not the full mentioned variables. So it may try to capture a field of an opaque (because the hidden type is known to be something with a field).

…param-env, r=oli-obk Remove `constness` from `ParamEnv` This should be replaced by keyword generics/effects. cc rust-lang#110395 r? `@oli-obk`

…arn, r=compiler-errors make `noop_method_call` warn by default r? `@compiler-errors`

…lstrieb Rename and allow `cast_ref_to_mut` lint This PR is a small subset of rust-lang#112431, that is the renaming of the lint (`cast_ref_to_mut` -> `invalid_reference_casting`). BUT also temporarily change the default level of the lint from deny-by-default to allow-by-default until rust-lang#112431 is merged. r? `@Nilstrieb`

…rkingjubilee Mark `map_or` as `#[must_use]` I don't know what else to say. r? libs

…new`

… colored and uncolored printing

[`unnecessary_mut_passed`]: don't lint in macro expansions Fixes rust-lang#11268 changelog: [`unnecessary_mut_passed`]: don't lint in macro expansions

Alphabetically order arms in `methods/mod.rs` match changelog: none just order the arms in the match block

[`unwrap_used`]: Do not lint unwrapping on `!` or never-like enums Fixes rust-lang#11245 changelog: [`unwrap_used`]: Do not lint unwrapping on `!` or never-like enums changelog: [`expect_used`]: Do not lint unwrapping on `!` or never-like enums

Suppress `question_mark` warning if `question_mark_used` is not allowed Closes rust-lang#11283 changelog: [`question_mark`]: Don't lint if `question_mark_used` is not allowed

[`ptr_as_ptr`]: Take snippet instead of pretty printing type Fixes rust-lang#11278 changelog: [`ptr_as_ptr`]: Include leading `super`s in suggestion

Co-authored-by: Dirkjan Ochtman <[email protected]>

…=xFrednet,djc [`slow_vector_initialization`]: clarify why `Vec::new()` + resize is worse rust-lang#11198 extended this lint to also warn on `Vec::new()` + `resize(0, len)`, but did not update the lint documentation, so it left some confused (rust-lang/rust-clippy#10938 (comment)). This PR should make it a bit more clear. (cc `@djc` `@vi` what do you think about this?) <details> <summary>More details</summary> Godbolt for `Vec::new()` + `.resize(x, 0)`: https://godbolt.org/z/e7q9xc9rG The resize call first does a normal allocation (`__rust_alloc`): ```asm alloc::raw_vec::finish_grow: ... cmp qword ptr [rcx + 8], 0 je .LBB1_7 ; if capacity == 0 -> LBB1_7 .LBB1_7: ... call qword ptr [rip + __rust_alloc@GOTPCREL] ``` *Then* a memset for zero initialization: ```asm example::f: ... xor esi, esi ; 0 call qword ptr [rip + memset@GOTPCREL] ``` ------------ Godbolt for `vec![0; len]`: https://godbolt.org/z/M3vr53vWY Important bit: ```asm example::f: ... call qword ptr [rip + __rust_alloc_zeroed@GOTPCREL] ``` </details> changelog: [`slow_vector_initialization`]: clarify why `Vec::new()` + resize is worse than `vec![0; len]`

[`filter_map_bool_then`]: Don't ICE on late bound regions Fixes rust-lang#11309 Also lints `&NonCopy` now, since any `&` is `Copy`. That was accidental, but it seems that this is a consequence (or improvement!) of this fix. r? `@Jarcho` changelog: [`filter_map_bool_then`]: Don't ICE on late bound regions

When a mutable binding is shadowed by a mutable binding of the same name in a different scope, mutations in that scope have different meaning. This commit fixes spurious `redundant_locals` emissions on such locals.

Rustup r? `@ghost` cc `@max-niederman` With the latest sync, I'm getting a lot of FP in the `redundant_locals` lint you recently added. Any ideas where this could come from? changelog: none

…_mutated, r=Alexendoo redundant_locals: fix FPs on mutated shadows Fixes rust-lang#11290. When a mutable binding is shadowed by a mutable binding of the same name in a different scope, mutations in that scope have different meaning. This PR fixes spurious `redundant_locals` emissions on such locals. cc `@Centri3,` `@flip1995` changelog: [`redundant_locals`]: fix false positives on mutated shadows

rustbot · 2023-08-11T12:07:25Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Centri3 · 2023-08-11T13:27:00Z

Well, I guess the revert was entirely unnecessary 😅 I didn't expect it to get into this sync, ah well

flip1995 · 2023-08-11T14:17:35Z

Better save than sorry :) Thanks for keeping up with stuff like this!

Manishearth · 2023-08-11T14:43:34Z

@bors r+ p=1

yeah totally fine to be eager about reverts, syncs can fail for a load of reasons

just try to pay attention to the syncs when they happen so the revert gets properly included

bors · 2023-08-11T14:43:36Z

📌 Commit 852bf4e has been approved by Manishearth

It is now in the queue for this repository.

bors · 2023-08-11T14:46:11Z

⌛ Testing commit 852bf4e with merge b03864d...

bors · 2023-08-11T17:24:51Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing b03864d to master...

rust-timer · 2023-08-11T18:45:42Z

Finished benchmarking commit (b03864d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.6%, -0.6%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.877s -> 631.671s (-0.19%)

Urgau and others added 30 commits July 13, 2023 23:01

Rename cast_ref_to_mut to invalid_reference_casting (clippy side)

50da775

redundant_type_annotations: only pass certain def kinds to type_of

d4f735c

fix

1662fdb

Perform OpaqueCast field projection on HIR, too.

d94d85f

This is necessary for closure captures in 2021 edition, as they capture individual fields, not the full mentioned variables. So it may try to capture a field of an opaque (because the hidden type is known to be something with a field).

Remove constness from ParamEnv

be0b4d5

bless clippy

39fb315

Auto merge of rust-lang#114134 - fee1-dead-contrib:rm-constness-from-…

e97a770

…param-env, r=oli-obk Remove `constness` from `ParamEnv` This should be replaced by keyword generics/effects. cc rust-lang#110395 r? `@oli-obk`

Make Clippy understand generic const items

4c9d68e

Auto merge of rust-lang#111916 - fee1-dead-contrib:noop-method-call-w…

0c0026e

…arn, r=compiler-errors make `noop_method_call` warn by default r? `@compiler-errors`

Mark map_or as #[must_use]

0c93e30

Rollup merge of rust-lang#112655 - WaffleLapkin:must_use_map_or, r=wo…

f54263a

…rkingjubilee Mark `map_or` as `#[must_use]` I don't know what else to say. r? libs

Use builder pattern instead of lots of arguments for `EmitterWriter::…

9a0af82

…new`

Remove a bool for color in favor of the WriteColor trait wrapping…

084c90a

… colored and uncolored printing

[unnecessary_mut_passed]: don't lint in macro expansions

dc1e8b0

New lint ignored_unit_patterns

f9a6dfa

Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup

b0e64a9

Auto merge of rust-lang#11269 - y21:issue11268, r=Centri3

588c1ab

[`unnecessary_mut_passed`]: don't lint in macro expansions Fixes rust-lang#11268 changelog: [`unnecessary_mut_passed`]: don't lint in macro expansions

Rename incorrect_fn_null_checks to useless_ptr_null_checks (clippy side)

7ef1a54

fix RedundantLocals clippy caused by async and await

0ff6579

Alphabetically order arms in methods/mod.rs match

72074a0

Auto merge of rust-lang#11284 - lengyijun:reorder, r=blyxyas

78f5e0d

Alphabetically order arms in `methods/mod.rs` match changelog: none just order the arms in the match block

Remove constness from TraitPredicate

b07de24

Do not lint unwrapping on ! or never-like enums

779e0f4

Extract never-like into clippy_utils

71c5413

Suppress question_mark if question_mark_used is not allowed

4d49065

Auto merge of rust-lang#11286 - Centri3:rust-lang#11283, r=Alexendoo

97d1cfa

Suppress `question_mark` warning if `question_mark_used` is not allowed Closes rust-lang#11283 changelog: [`question_mark`]: Don't lint if `question_mark_used` is not allowed

Take snippet instead of pretty printing type

fef85c9

Auto merge of rust-lang#11288 - Centri3:rust-lang#11278, r=Alexendoo

237dd59

[`ptr_as_ptr`]: Take snippet instead of pretty printing type Fixes rust-lang#11278 changelog: [`ptr_as_ptr`]: Include leading `super`s in suggestion

y21 and others added 15 commits August 9, 2023 14:08

clarify why Vec::new() + resize is worse than vec![0; N]

830bac5

Reword paragraph

d2acfb3

Co-authored-by: Dirkjan Ochtman <[email protected]>

Remove unnecessary paragraph, move examples

dd25cc3

Merge remote-tracking branch 'upstream/master' into rustup

17b9c42

Bump nightly version -> 2023-08-10

61e9b15

Don't ICE with late bound regions

beb57f0

Add test for &mut

7b2fd81

redundant_locals: fix FPs on mutated shadows

a5f62bd

When a mutable binding is shadowed by a mutable binding of the same name in a different scope, mutations in that scope have different meaning. This commit fixes spurious `redundant_locals` emissions on such locals.

Fix redundant_locals for Async desugaring

0fc051d

Dogfood and bless tests

3927677

Auto merge of rust-lang#11316 - flip1995:rustup, r=flip1995

8703661

Rustup r? `@ghost` cc `@max-niederman` With the latest sync, I'm getting a lot of FP in the `redundant_locals` lint you recently added. Any ideas where this could come from? changelog: none

Merge commit '1e8fdf492808a25d78a97e1242b835ace9924e4d' into clippyup

852bf4e

rustbot assigned Manishearth Aug 11, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 11, 2023

bors merged commit b03864d into rust-lang:master Aug 11, 2023

rustbot added this to the 1.73.0 milestone Aug 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Clippy #114729

Update Clippy #114729

Uh oh!

flip1995 commented Aug 11, 2023

Uh oh!

rustbot commented Aug 11, 2023

Uh oh!

Centri3 commented Aug 11, 2023

Uh oh!

flip1995 commented Aug 11, 2023 •

edited

Loading

Uh oh!

Manishearth commented Aug 11, 2023

Uh oh!

bors commented Aug 11, 2023

Uh oh!

bors commented Aug 11, 2023

Uh oh!

bors commented Aug 11, 2023

Uh oh!

rust-timer commented Aug 11, 2023

Uh oh!

Uh oh!

Update Clippy #114729

Update Clippy #114729

Uh oh!

Conversation

flip1995 commented Aug 11, 2023

Uh oh!

rustbot commented Aug 11, 2023

Uh oh!

Centri3 commented Aug 11, 2023

Uh oh!

flip1995 commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Manishearth commented Aug 11, 2023

Uh oh!

bors commented Aug 11, 2023

Uh oh!

bors commented Aug 11, 2023

Uh oh!

bors commented Aug 11, 2023

Uh oh!

rust-timer commented Aug 11, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

flip1995 commented Aug 11, 2023 •

edited

Loading