Skip to content

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 2, 2023

10 commits in c91a693e7977e33a1064b63a5daf5fb689f01651..020651c52257052d28f6fd83fbecf5cfa1ed516c
2023-07-31 00:26:46 +0000 to 2023-08-02 16:00:37 +0000

r? @ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

Feel pretty safe to include this in a rollup. We'll see.

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

📌 Commit f703aa5 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2023
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Aug 2, 2023
Update cargo

8 commits in c91a693e7977e33a1064b63a5daf5fb689f01651..6dc1deaddf62c7748c9097c7ea88e9ec77ff1a1a
2023-07-31 00:26:46 +0000 to 2023-08-02 00:23:54 +0000
- `#[allow(internal_features)]` in RUSTC_BOOTSTRAP test (rust-lang/cargo#12429)
- ci: rewrite bump check and respect semver (rust-lang/cargo#12395)
- fix(update): Tweak CLI behavior (rust-lang/cargo#12428)
- chore(deps): update compatible (rust-lang/cargo#12426)
- Display crate version on timings graph (rust-lang/cargo#12420)
- chore(deps): update alpine docker tag to v3.18 (rust-lang/cargo#12427)
- Use thiserror for credential provider errors (rust-lang/cargo#12424)
- Clarify in `--help` that `cargo test --all-targets` excludes doctests (rust-lang/cargo#12422)

r? `@ghost`
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Aug 2, 2023
Update cargo

8 commits in c91a693e7977e33a1064b63a5daf5fb689f01651..6dc1deaddf62c7748c9097c7ea88e9ec77ff1a1a
2023-07-31 00:26:46 +0000 to 2023-08-02 00:23:54 +0000
- `#[allow(internal_features)]` in RUSTC_BOOTSTRAP test (rust-lang/cargo#12429)
- ci: rewrite bump check and respect semver (rust-lang/cargo#12395)
- fix(update): Tweak CLI behavior (rust-lang/cargo#12428)
- chore(deps): update compatible (rust-lang/cargo#12426)
- Display crate version on timings graph (rust-lang/cargo#12420)
- chore(deps): update alpine docker tag to v3.18 (rust-lang/cargo#12427)
- Use thiserror for credential provider errors (rust-lang/cargo#12424)
- Clarify in `--help` that `cargo test --all-targets` excludes doctests (rust-lang/cargo#12422)

r? ``@ghost``
@Noratrieb
Copy link
Member

something's messed up in rustix on loongarch: #114367 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 2, 2023
@weihanglo
Copy link
Member Author

Sorry @Nilstrieb. I thought it was safe to help unblock your PR. I'll take a look then.

@Noratrieb
Copy link
Member

https://github.com/rust-lang/libc/blob/28ab9b9e7bd04a5c5aca3f4d78583214f63d4002/src/unix/linux_like/linux/gnu/b64/loongarch64/mod.rs#L322 libc does indeed not have SYS_open for loongarch64

@Noratrieb
Copy link
Member

this was fixed in bytecodealliance/rustix#751
@weihanglo

@weihanglo
Copy link
Member Author

weihanglo commented Aug 2, 2023

@heiher could you help fix this?
(Sorry you are the only one I know working on loongarch)

EDIT: guess just need a rustix bump.

@heiher
Copy link
Contributor

heiher commented Aug 2, 2023

@heiher could you help fix this? (Sorry you are the only one I know working on loongarch)

EDIT: guess just need a rustix bump.

Yeah. I think we just need a new release of rustix.

bors added a commit to rust-lang/cargo that referenced this pull request Aug 2, 2023
Update rustix to 0.38.6

### What does this PR try to resolve?

Resolve build breaks for LoongArch: rust-lang/rust#114364

### How should we test and review this PR?

```bash
cargo build --target=loongarch64-unknown-linux-gnu
```

### Additional information

None
@weihanglo
Copy link
Member Author

Thanks everyone.

Let's do it again.

@bors r+ p=1 rollup=never

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

📌 Commit 1f960bc has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2023
@bors
Copy link
Collaborator

bors commented Aug 2, 2023

⌛ Testing commit 1f960bc with merge 8131b97...

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 8131b97 to master...

@bors
Copy link
Collaborator

bors commented Aug 2, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 8131b97 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Aug 2, 2023
@bors bors merged commit 8131b97 into rust-lang:master Aug 2, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 2, 2023
@weihanglo weihanglo deleted the update-cargo branch August 3, 2023 06:19
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8131b97): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.281s -> 647.939s (-0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants