Skip to content

Use log groups in opt-dist #113749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2023
Merged

Use log groups in opt-dist #113749

merged 1 commit into from
Jul 16, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 16, 2023

Some of the output was quite verbose in CI logs, this should help with that.

r? bootstrap

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2023
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 16, 2023

@bors try

@bors
Copy link
Collaborator

bors commented Jul 16, 2023

⌛ Trying commit cca3fb27f28066dfbf00e33d0063243130a2fe3d with merge f06e6a527d989cb72b31a83c056f64fee30d49ce...

@Kobzol
Use log groups in opt-dist
e04b915 
Some of the output was quite verbose in CI logs, this should help with that.
@Kobzol Kobzol force-pushed the opt-dist-ci-group branch from cca3fb2 to e04b915 Compare July 16, 2023 08:36
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 16, 2023 •
edited
Loading

Hmm, the groups do not seem to play nice with intermingling stdout and stderr. I converted some logs to printlns to improve the output.

@clubby789
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 16, 2023

📌 Commit e04b915 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2023
@bors
Copy link
Collaborator

bors commented Jul 16, 2023

⌛ Testing commit e04b915 with merge cc7d9d5...

@bors
Copy link
Collaborator

bors commented Jul 16, 2023

☀️ Test successful - checks-actions
Approved by: clubby789
Pushing cc7d9d5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2023
@bors bors merged commit cc7d9d5 into rust-lang:master Jul 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 16, 2023
@Kobzol Kobzol deleted the opt-dist-ci-group branch July 16, 2023 19:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cc7d9d5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.937s -> 657.237s (-0.11%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@clubby789 clubby789

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kobzol @bors @clubby789 @rust-timer @rustbot