Don't perform selection if inherent associated types are not enabled #113286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
iat-dont-select-if-not-enabled
branch
from
b8f71be to
838f85d
Compare
fmease
commented
Jul 3, 2023
| @@ -1,40 +1,40 @@ | |||
| error: `Self` is not valid in the self type of an impl block | |||
There was a problem hiding this comment.
For some reason my change leads to a reordering of diagnostics. Shouldn't matter too much.
compiler-errors
approved these changes
Jul 3, 2023
|
@bors r+ rollup (only really affects the error path) |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 3, 2023
…llaumeGomez Rollup of 3 pull requests Successful merges: - rust-lang#112869 (Implement selection via new trait solver) - rust-lang#113285 ([rustdoc] Fix display of long inline cfg labels) - rust-lang#113286 (Don't perform selection if inherent associated types are not enabled) r? `@ghost` `@rustbot` modify labels: rollup
fmease
added
the
F-inherent_associated_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113265.
As discussed
r? @compiler-errors