Skip to content

Conversation

zephaniahong
Copy link
Contributor

@zephaniahong zephaniahong commented Jun 22, 2023

Displays PID of process holding lock when trying to run multiple instances of x.py

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 22, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@zephaniahong zephaniahong marked this pull request as ready for review June 23, 2023 07:10
@Mark-Simulacrum
Copy link
Member

r=me with description updated to reflect fixed PID writing

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2023
@zephaniahong
Copy link
Contributor Author

zephaniahong commented Jun 25, 2023

@Mark-Simulacrum to clarify, do you need me to just edit the description in this PR? (I've done what I think you want me to. Let me know if it's correct😅)

Thank you!

@zephaniahong zephaniahong changed the title naive attempt at displaying PID of process holding lock display PID of process holding lock Jun 25, 2023
@Mark-Simulacrum
Copy link
Member

Yes, thanks! @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 25, 2023

📌 Commit e7e584b has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 25, 2023
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112918 (display PID of process holding lock)
 - rust-lang#112990 (Add a regression test for rust-lang#96699)
 - rust-lang#113011 (Add enum for `can_access_statics` boolean)
 - rust-lang#113018 (Fix test for rust-lang#96258)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fb98925 into rust-lang:master Jun 25, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants