Skip to content

Conversation

compiler-errors
Copy link
Member

Instead of, e.g.

PredefinedOpaques(Interned(PredefinedOpaquesData { ... }, PrivateZst))

print:

PredefinedOpaques(PredefinedOpaquesData { ... })

Mostly observable in debug logs, or ICE backtraces where I saw this.

r? @nnethercote

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 9, 2023
@nnethercote
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 9, 2023

📌 Commit 80e9ca9 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
@nnethercote
Copy link
Contributor

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 9, 2023
…ethercote

Don't debug-print `Interned` or `PrivateZst`

Instead of, e.g.

`PredefinedOpaques(Interned(PredefinedOpaquesData { ... }, PrivateZst))`

print:

`PredefinedOpaques(PredefinedOpaquesData { ... })`

Mostly observable in debug logs, or ICE backtraces where I saw this.

r? `@nnethercote`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#112323 (Don't mention already-set fields in struct constructor missing field error)
 - rust-lang#112395 (Add Terminator::InlineAsm conversion from MIR to SMIR)
 - rust-lang#112411 (add programmerjake to portable-simd cc list)
 - rust-lang#112428 (Structurally resolve pointee in `check_pat_lit`)
 - rust-lang#112444 (Don't debug-print `Interned` or `PrivateZst`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 009fc56 into rust-lang:master Jun 9, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 9, 2023
@compiler-errors compiler-errors deleted the intern-debug branch August 11, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants