Don't compile rustc to self-test compiletest #112256
Conversation
This was changed from stage 0 to 1 in rust-lang#108905, but I'm not sure why. Change it to `top_stage` instead to allow people to choose the stage. This should save quite a bit of time in the `mingw-check` builder, which explicitly runs `x test --stage 0 compiletest`.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
this is consistent with std and makes it much easier to understand what's actually happening
this gives a more helpful backtrace if it fails
before:
```
thread 'main' panicked at 'symlink_dir_force(&builder.config, &out, &out_dir) failed with No such file or directory (os error 2)', doc.rs:697:9
```
after:
```
thread 'main' panicked at 'symlink_dir(config, original, link) failed with No such file or directory (os error 2) ("failed to create link from /home/jyn/src/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/doc -> /home/jyn/src/rust2/build/x86_64-unknown-linux-gnu/compiler-doc")', doc.rs:975:5
```
|
...not sure why I did that, but maybe it was because I needed the new |
|
it works fine - this is the stage compiletest is built with, which has no relation to the compiler under test. |
|
@bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (b8a5001): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 649.872s -> 649.051s (-0.13%) |
This was changed from stage 0 to 1 in #108905, but I'm not sure why. Change it to
top_stageinstead to allow people to choose the stage.This should save quite a bit of time in the
mingw-checkbuilder, which explicitly runsx test --stage 0 compiletest.Note that this also fixes a latent bug that depended on running
x build compilerbeforex doc compiler, as well as a couple cleanups related to symlinks (which made the latent bug easier to find).cc @pietroalbini