Skip to content

Rename InstCombine to InstSimplify #111309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

Rename InstCombine to InstSimplify #111309

merged 1 commit into from
May 8, 2023

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented May 7, 2023 

╭ ➜ ben@archlinux:~/rust
╰ ➤ rg -i instcombine
src/doc/rustc-dev-guide/src/mir/optimizations.md
134:may have been misapplied. Examples of this are `InstCombine` and `ConstantPropagation`.

src/ci/docker/host-x86_64/disabled/dist-x86_64-haiku/llvm-config.sh
38:                    instcombine instrumentation interpreter ipo irreader lanai \

tests/codegen/slice_as_from_ptr_range.rs
4:// min-llvm-version: 15.0 (because this is a relatively new instcombine)

r? @scottmcm

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 7, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@saethlin saethlin mentioned this pull request May 7, 2023
Merged
@scottmcm
Copy link
Member

scottmcm commented May 7, 2023

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented May 7, 2023

📌 Commit ff85554 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2023
@bors
Copy link
Collaborator

bors commented May 8, 2023

⌛ Testing commit ff85554 with merge 04c5344...

@bors
Copy link
Collaborator

bors commented May 8, 2023

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 04c5344 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2023
@bors bors merged commit 04c5344 into rust-lang:master May 8, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 8, 2023
@bors bors mentioned this pull request May 8, 2023
Merged
@saethlin saethlin deleted the InstSimplify branch May 9, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@saethlin @rustbot @scottmcm @bors