Skip to content

fix out-of-date comment about rpath in bootstrap #110574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix out-of-date comment about rpath in bootstrap #110574

merged 1 commit into from
Apr 20, 2023

Conversation

wangkirin
Copy link
Contributor

@wangkirin wangkirin commented Apr 20, 2023 •
edited
Loading

in #64316 (1bec962), the RUSTC_RPATH enviroment variables had been removed , but the comments about the rpath still keep it
this PR fix it to avoid misunstanding

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 20, 2023
@wangkirin wangkirin changed the title fix out of date comment about rpath in bootstrap fix out-of-date comment about rpath in bootstrap Apr 20, 2023
@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 20, 2023

📌 Commit 4bd363a has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2023
@bors
Auto merge of rust-lang#110598 - matthiaskrgr:rollup-0ybd9i3, r=matth…
791a7f2 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#110240 (Add `indent_style = tab` for `Makefile`s to `.editorconfig`)
 - rust-lang#110545 (Add `GenericArgKind::as_{type,const,region}`)
 - rust-lang#110574 ( fix out-of-date comment about rpath in bootstrap)
 - rust-lang#110581 (Style fix for loongarch-linux.md)
 - rust-lang#110584 (Allow overwriting the sysroot compile flag in compile tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b577dd3 into rust-lang:master Apr 20, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wangkirin @rustbot @albertlarsan68 @bors