De-closure-ify/remove vec & str .as_{imm,mut}_buf #11029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! |
There's no need for the restrictions of a closure with the above methods.
`.as_mut_buf` was used exactly once, in `.push_char` which could be written in a simpler way, using the `&mut ~[u8]` that it already retrieved. In the rare situation when someone really needs `.as_mut_buf`-like functionality (getting a `*mut u8`), they can go via `str::raw::as_owned_vec`.
bors
added a commit
that referenced
this pull request
Dec 19, 2013
For `str.as_mut_buf`, un-closure-ification is achieved by outright removal (see commit message). The others are replaced by `.as_ptr`, `.as_mut_ptr` and `.len`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
Make `comparison_to_empty` work on `if let`/`let` chains This adds `LetChain` to `clippy_utils::higher`, other lints may benefit from such a change as well :D changelog: Enhancement: [`comparison_to_empty`]: Now lints on `if let`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
str.as_mut_buf, un-closure-ification is achieved by outright removal (see commit message). The others are replaced by.as_ptr,.as_mut_ptrand.len