Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2023

Fixes #110020

@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2023

r? @ozkanonur

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 7, 2023
@ghost ghost marked this pull request as draft April 7, 2023 18:01
@ghost

This comment was marked as outdated.

@rust-log-analyzer

This comment has been minimized.

@ghost ghost marked this pull request as ready for review April 8, 2023 05:38
Copy link
Member

@KittyBorgX KittyBorgX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@onur-ozkan
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 8, 2023

📌 Commit c80a694 has been approved by ozkanonur

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2023
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110058 (Remove `box_syntax` usage)
 - rust-lang#110059 (ignore_git → omit_git_hash)
 - rust-lang#110060 (Document that `&T` and `&mut T` are `Sync` if `T` is)
 - rust-lang#110074 (Make the "codegen" profile of `config.toml` download and build llvm from source.)
 - rust-lang#110086 (Add `max_line_length` to `.editorconfig`, matching rustfmt)
 - rust-lang#110096 (Tweak tuple indexing suggestion)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec1712f into rust-lang:master Apr 9, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 9, 2023
…gelog, r=ozkanonur

Add renaming of ignore-git to changelog

`bootstrap`'s `ignore-git` option has been renamed to `omit-git-hash` in rust-lang#110059. This PR adds this change to the `CHANGELOG.md`. See also rust-lang#110020 (comment).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 9, 2023
…gelog, r=ozkanonur

Add renaming of ignore-git to changelog

`bootstrap`'s `ignore-git` option has been renamed to `omit-git-hash` in rust-lang#110059. This PR adds this change to the `CHANGELOG.md`. See also rust-lang#110020 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ignore-git to omit-git-hash
5 participants