Skip to content

Conversation

compiler-errors
Copy link
Member

Fixes an ICE where we call layout_of on a type with infer regions.

@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 7, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the infer-regions-in-transmutability branch from b1df07d to c46328a Compare April 7, 2023 06:50
@petrochenkov
Copy link
Contributor

r? @scottmcm to balance #110021 (comment)

@rustbot rustbot assigned scottmcm and unassigned petrochenkov Apr 7, 2023
@scottmcm
Copy link
Member

scottmcm commented Apr 7, 2023

This looks plausible to me -- not having the Binder in the is_transmutable is a nice change -- but I don't think I know enough about what's going on here to be confident in signing-off.

r? types

@rustbot rustbot assigned spastorino and unassigned scottmcm Apr 7, 2023
@spastorino
Copy link
Member

r? types

@rustbot rustbot assigned lcnr and unassigned spastorino Apr 13, 2023
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, then r=me

@rust-cloud-vms rust-cloud-vms bot force-pushed the infer-regions-in-transmutability branch from c46328a to f6bfb4b Compare April 16, 2023 19:18
@rustbot rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Apr 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@compiler-errors
Copy link
Member Author

Addressed the comment nit and rebased past a PR that changed the transmutability API slightly (no more binder for an argument).

We lose a 'static in an error message, but that's not particularly important IMO, since again, lifetimes don't affect transmutability.

@bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented Apr 16, 2023

📌 Commit f6bfb4b has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#110038 (Erase regions when confirming transmutability candidate)
 - rust-lang#110341 (rustdoc: stop passing a title to `replaceState` second argument)
 - rust-lang#110388 (Add a message for if an overflow occurs in `core::intrinsics::is_nonoverlapping`.)
 - rust-lang#110404 (fix clippy::toplevel_ref_arg and ::manual_map)
 - rust-lang#110421 (Spelling librustdoc)
 - rust-lang#110423 (Spelling srcdoc)
 - rust-lang#110433 (Windows: map a few more error codes to ErrorKind)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f5222cd into rust-lang:master Apr 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 17, 2023
@compiler-errors compiler-errors deleted the infer-regions-in-transmutability branch August 11, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants