Skip to content

Refactor glibc time64 support, riscv32 always has 64-bit time_t #109784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

Refactor glibc time64 support, riscv32 always has 64-bit time_t #109784

merged 1 commit into from
Mar 31, 2023
+36 −14

Conversation

beetrees
Copy link
Contributor

Refactor existing support for 64-bit time_t on 32-bit glibc platforms, as riscv32 time_t is 64-bit by default. Split out of #109773.

@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@beetrees beetrees mentioned this pull request Mar 30, 2023
Merged
@cuviper cuviper assigned cuviper and unassigned Mark-Simulacrum Mar 30, 2023
@cuviper
Copy link
Member

cuviper commented Mar 30, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 30, 2023

📌 Commit 8d1bf50 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2023
@bors
Auto merge of rust-lang#109803 - matthiaskrgr:rollup-mojot7k, r=matth…
ec7bb8d 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#109598 (Improve documentation for str::replace() and str::replacen())
 - rust-lang#109779 (Update gccjit and remove libc 0.1 dependency)
 - rust-lang#109784 (Refactor glibc time64 support, riscv32 always has 64-bit `time_t`)
 - rust-lang#109793 (add comment to `impl !Error for &str`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0708fbf into rust-lang:master Mar 31, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 31, 2023
@beetrees beetrees deleted the riscv32-time64 branch March 31, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@beetrees @rustbot @cuviper @bors @Mark-Simulacrum