Skip to content

autoderive Subdiagnostic for AddtoExternBlockSuggestion #107068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

autoderive Subdiagnostic for AddtoExternBlockSuggestion #107068

merged 1 commit into from
Jan 20, 2023

Conversation

mejrs
Copy link
Contributor

@mejrs mejrs commented Jan 19, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@estebank
Copy link
Contributor

r? @estebank

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 19, 2023

📌 Commit cc5af33 has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned cjgillot Jan 19, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 20, 2023
@matthiaskrgr
Rollup merge of rust-lang#107068 - mejrs:use_derive, r=estebank
f20da04 
autoderive Subdiagnostic for AddtoExternBlockSuggestion
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2023
@bors
Auto merge of rust-lang#107106 - matthiaskrgr:rollup-g7r1ep0, r=matth…
a6269da 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106699 ([drop tracking] Visit break expressions )
 - rust-lang#106738 (Fix known-bug annotations)
 - rust-lang#106891 (Tweak "borrow closure argument" suggestion)
 - rust-lang#106928 (add raw identifier for keyword in suggestion)
 - rust-lang#107065 (Clippy: Make sure to include in beta: Move `unchecked_duration_subtraction` to pedantic)
 - rust-lang#107068 (autoderive Subdiagnostic for AddtoExternBlockSuggestion)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c44c60c into rust-lang:master Jan 20, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mejrs @rustbot @estebank @bors @cjgillot