PERF: split dwarf after #106709

[davidtwco]

Checking the impact of #106709 on Split DWARF's performance impact.

r? @ghost

[davidtwco]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 6facfe7 with merge 33f2e97df98858c33223f0affcfdf9c3db5a4f4c...

[bors]

☀️ Try build successful - checks-actions
Build commit: 33f2e97df98858c33223f0affcfdf9c3db5a4f4c (33f2e97df98858c33223f0affcfdf9c3db5a4f4c)

[rust-timer]

Finished benchmarking commit (33f2e97df98858c33223f0affcfdf9c3db5a4f4c): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-13.7%	[-29.3%, -0.7%]	18
Improvements ✅ (secondary)	-12.4%	[-28.7%, -1.3%]	70
All ❌✅ (primary)	-13.7%	[-29.3%, -0.7%]	18

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.5%, 0.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-2.1%, 0.8%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-12.8%	[-22.3%, -0.9%]	14
Improvements ✅ (secondary)	-10.3%	[-21.9%, -1.8%]	63
All ❌✅ (primary)	-12.8%	[-22.3%, -0.9%]	14

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Successfully built a782d64d8228
Successfully tagged rust-ci:latest
Built container sha256:a782d64d8228658fe3cfe42961037061b219e0c52153bbaaa3bf8a07910daa24
Uploading finished image to https://ci-caches.rust-lang.org/docker/d33e4deadd55ac310bf6d14046967e2ae76df1d0cbcfb3cbdfd57a515110e5c43bea0fc68be40129a2ca62a8c3c0cddee210b82b000006fe1b3d251a4634baf3
upload failed: - to s3://rust-lang-ci-sccache2/docker/d33e4deadd55ac310bf6d14046967e2ae76df1d0cbcfb3cbdfd57a515110e5c43bea0fc68be40129a2ca62a8c3c0cddee210b82b000006fe1b3d251a4634baf3 Unable to locate credentials
[CI_JOB_NAME=mingw-check-tidy]
[CI_JOB_NAME=mingw-check-tidy]
---
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
Attempting with retry: make prepare
---
Highest error code: `E0791`
* 393 features
fmt check
skip untracked path cpu-usage.csv during rustfmt invocations
Diff in /checkout/src/bootstrap/config.rs at line 887:
         // We still support running outside the repository if we find we aren't in a git directory.
         cmd.arg("rev-parse").arg("--show-toplevel");
         // Discard stderr because we expect this to fail when building from a tarball.
-        let output = cmd.stderr(std::process::Stdio::null()).output().ok().and_then(|output| {
-            if output.status.success() {
-                Some(output)
-                None
-            }
-        });
+        let output = cmd
+        let output = cmd
+            .stderr(std::process::Stdio::null())
+            .output()
+            .ok()
+            .and_then(|output| if output.status.success() { Some(output) } else { None });
         if let Some(output) = output {
             let git_root = String::from_utf8(output.stdout).unwrap();
             // We need to canonicalize this path to make sure it uses backslashes instead of forward slashes.
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/src/bootstrap/tool.rs" "/checkout/src/bootstrap/config.rs" "/checkout/src/bootstrap/bin/rustc.rs" "/checkout/src/bootstrap/compile.rs" "/checkout/src/bootstrap/tarball.rs" "/checkout/src/bootstrap/test.rs" "/checkout/src/bootstrap/dylib_util.rs" "/checkout/src/bootstrap/channel.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.