Remove backwards compat for LLVM 12 coverage format #106625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
nagisa
reviewed
Jan 9, 2023
|
@bors r+ |
|
📌 Commit 84462e1174e9c358dbd9889a8bdfbfb7848f4c24 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
I amended the commit, removing the error message in favor of an assertion. |
|
@bors r+ Sorry for the delay T_T |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#97373 (impl DispatchFromDyn for Cell and UnsafeCell) - rust-lang#106625 (Remove backwards compat for LLVM 12 coverage format) - rust-lang#106779 (Avoid __cxa_thread_atexit_impl on Emscripten) - rust-lang#106811 (Append .dwp to the binary filename instead of replacing the existing extension.) - rust-lang#106836 (Remove optimistic spinning from `mpsc::SyncSender`) - rust-lang#106946 (implement Hash for proc_macro::LineColumn) - rust-lang#107074 (remove unnecessary check for opaque types) - rust-lang#107287 (Improve fn pointer notes) - rust-lang#107304 (Use `can_eq` to compare types for default assoc type error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
tshepang
added a commit
to tshepang/rustc-dev-guide
that referenced
this pull request
Jan 27, 2023
workingjubilee
added
the
A-LLVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum external LLVM was updated to 13 recently in #100611, so this PR removes backwards compat with older coverage formats.
I kept the version check and error message there, in accordance with this comment: #91207 (comment)