Remove old version of cfg-if by bumping packed_simd_2 and getrandom v0.2 versions
#106033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old versions of `cfg-if` by bumping `packed_simd_2` and `getrandom v0.2` versions ```console > cargo update --package packed_simd_2 --package [email protected] Updating crates.io index Removing cfg-if v0.1.10 Updating getrandom v0.2.0 -> v0.2.8 Updating packed_simd_2 v0.3.4 -> v0.3.8 ``` `packed_simd_2` is only used as a dependency `bytecount`. The bigger jump is `[email protected]`, but it's still semver compatible and there doesn't seem to be any worrying changes (see the [changelog](https://github.com/rust-random/getrandom/blob/master/CHANGELOG.md)). Note that this doesn't affect `[email protected]`, which is already using the latest version of `cfg-if` (besides, there are already plans to remove that entirely).
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
|
@bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…lacrum Remove old version of `cfg-if` by bumping `packed_simd_2` and `getrandom v0.2` versions ```console > cargo update --package packed_simd_2 --package [email protected] Updating crates.io index Removing cfg-if v0.1.10 Updating getrandom v0.2.0 -> v0.2.8 Updating packed_simd_2 v0.3.4 -> v0.3.8 ``` `packed_simd_2` is only used as a dependency of `bytecount` which in turn is only used by `rustfmt`. I can't see any issue with the minor version bump. The bigger jump is `[email protected]` which is used by a number of things, but 0.2.8 is still semver compatible and there doesn't seem to be any worrying changes (see the [changelog](https://github.com/rust-random/getrandom/blob/master/CHANGELOG.md)). The only breaking change are the removal of XP, stdweb and CloudAbi support but these are not host targets and rustc lacks support for them in any case (stdweb development was [abandonded](https://rustsec.org/advisories/RUSTSEC-2020-0056.html), XP is [tier 3 and `no_std`](https://doc.rust-lang.org/beta/rustc/platform-support.html#tier-3) and CloubAbi is [no longer supported](rust-lang#78439)). Note that this doesn't affect `[email protected]` which is what std depends on and which is already using the latest version of `cfg-if` (besides, there are already plans to remove that entirely).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packed_simd_2is only used as a dependency ofbytecountwhich in turn is only used byrustfmt. I can't see any issue with the minor version bump.The bigger jump is
[email protected]which is used by a number of things, but 0.2.8 is still semver compatible and there doesn't seem to be any worrying changes (see the changelog). The only breaking change are the removal of XP, stdweb and CloudAbi support but these are not host targets and rustc lacks support for them in any case (stdweb development was abandonded, XP is tier 3 andno_stdand CloubAbi is no longer supported).Note that this doesn't affect
[email protected]which is what std depends on and which is already using the latest version ofcfg-if(besides, there are already plans to remove that entirely).