Use u32 methods instead of manual shifting #105893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
|
@bors r+ rollup=iffy |
|
📌 Commit 6913efa626c3d8420a402588a80cf1f074a3cdfb has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6913efa626c3d8420a402588a80cf1f074a3cdfb with merge cbefec03be94fa09e4009d3b78cbb950c98daaf1... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6913efa626c3d8420a402588a80cf1f074a3cdfb with merge f749ff04a32e3fa1eec6296354546e391fab13ba... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
tmiasko
reviewed
Dec 23, 2022
Ayush1325
force-pushed
the
remote-test-server-improve
branch
from
6913efa to
102a07e
Compare
Switch to `to_be_bytes()` and `from_be_bytes()` instead of manual shifting This was suggested [`here`](rust-lang#105145 (comment)) Signed-off-by: Ayush Singh <[email protected]>
Ayush1325
force-pushed
the
remote-test-server-improve
branch
from
102a07e to
51fe248
Compare
|
@bors r+ |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (4f4d058): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…, r=Mark-Simulacrum Use u32 methods instead of manual shifting Switch to `to_le_bytes()` and `from_le_bytes()` instead of manual shifting This was suggested [`here`](rust-lang#105145 (comment)) Signed-off-by: Ayush Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
to_le_bytes()andfrom_le_bytes()instead of manual shiftingThis was suggested
hereSigned-off-by: Ayush Singh [email protected]