tutorial: rewrite the section vectors/strings #10354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Fixed-size vectors are an unboxed block of memory, with the element length as | ||
| part of the type. A fixed-size vector owns the elements it contains, so the | ||
| elements are mutable if the vector is mutable. Fixed-size strings do not exist, | ||
| because mutating a string may require altering the length. |
There was a problem hiding this comment.
Is it worth mentioning the limitations of fixed-size vectors (i.e. the fact they don't implement traits), just as a > Note: fixed-size vectors have bugs....?
(Also, this "because ..." doesn't seem necessary (i.e. just say "Fixed-size strings do not exist."), since e.g. string literals are immutable, so they could, in theory, be [u8, .. len] behind the scenes.)
There was a problem hiding this comment.
I think that limitation would belong in the more comprehensive manual.
This section desperately needs to be expanded, but removing the misleading/incorrect information is a priority. Managed vectors/strings are not covered, as they are feature-gated and are only a micro-optimization to avoid double-indirection. Closes #6882
bors
added a commit
that referenced
this pull request
Nov 8, 2013
This section desperately needs to be expanded, but removing the misleading/incorrect information is a priority. Managed vectors/strings are not covered, as they are feature-gated and are only a micro-optimization to avoid double-indirection. Closes #6882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section desperately needs to be expanded, but removing the
misleading/incorrect information is a priority.
Managed vectors/strings are not covered, as they are feature-gated and
are only a micro-optimization to avoid double-indirection.
Closes #6882