emit diagnostic suggestion for error when if let used with enum varia… #102062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
lyming2007
force-pushed
the
issue-101208
branch
from
f36a8be to
71846fe
Compare
|
☔ The latest upstream changes (presumably #98840) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #102306) made this pull request unmergeable. Please resolve the merge conflicts. |
…nt without being initialized compare the span base id to get the correct expression and add suggestion to it modified: compiler/rustc_infer/src/infer/error_reporting/mod.rs modified: compiler/rustc_span/src/span_encoding.rs modified: compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs modified: compiler/rustc_typeck/src/check/compare_method.rs modified: compiler/rustc_typeck/src/check/fn_ctxt/checks.rs new file: src/test/ui/type/issue-101208.rs new file: src/test/ui/type/issue-101208.stderr
lyming2007
force-pushed
the
issue-101208
branch
from
3adb0e0 to
cdcca2c
Compare
compiler-errors
requested changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt without being initialized
compare the span base id to get the correct expression and add suggestion to it
modified: compiler/rustc_infer/src/infer/error_reporting/mod.rs
modified: compiler/rustc_span/src/span_encoding.rs
modified: compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs
modified: compiler/rustc_typeck/src/check/compare_method.rs
modified: compiler/rustc_typeck/src/check/fn_ctxt/checks.rs
new file: src/test/ui/type/issue-101208.rs
new file: src/test/ui/type/issue-101208.stderr