Don't delay invalid LHS bug unless it will be covered by an error in check_overloaded_binop
#101388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n check_overloaded_binop
rustbot
added
the
T-compiler
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Sep 3, 2022
| | | ||
| help: consider dereferencing the left-hand side of this operation | ||
| | | ||
| LL | *(&mut Foo) += (); |
There was a problem hiding this comment.
This suggestion may be a bit strange here in this minimized example, but it makes sense if &mut Foo is coming from a function argument or something.
There was a problem hiding this comment.
FWIW, it looks like a function with a return type of &mut Foo can also trigger this ICE. foo() += ();
fee1-dead
reviewed
Sep 4, 2022
Comment on lines
+1
to
+19
| use std::ops::AddAssign; | ||
| struct Foo; | ||
|
|
||
| impl AddAssign<()> for Foo { | ||
| fn add_assign(&mut self, _: ()) {} | ||
| } | ||
|
|
||
| impl AddAssign<()> for &mut Foo { | ||
| fn add_assign(&mut self, _: ()) {} | ||
| } | ||
|
|
||
| fn main() { | ||
| (&mut Foo) += (); | ||
| //~^ ERROR invalid left-hand side of assignment | ||
| //~| NOTE cannot assign to this expression | ||
| //~| HELP consider dereferencing the left-hand side of this operation | ||
| } |
There was a problem hiding this comment.
Could you please link this to #101376?
| | | ||
| help: consider dereferencing the left-hand side of this operation | ||
| | | ||
| LL | *(&mut Foo) += (); |
There was a problem hiding this comment.
FWIW, it looks like a function with a return type of &mut Foo can also trigger this ICE. foo() += ();
compiler-errors
force-pushed
the
issue-101376
branch
from
e5c238b to
98f4b20
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 4, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#101322 (Fix internal doc link) - rust-lang#101385 (updated description of File struct in std::fs) - rust-lang#101388 (Don't delay invalid LHS bug unless it will be covered by an error in `check_overloaded_binop`) - rust-lang#101394 (Forbid mixing `System` with direct sytem allocator calls) - rust-lang#101397 (rustdoc: remove redundant mobile-sized `.source nav:not(.sidebar).sub`) - rust-lang#101401 (Make `char::is_lowercase` and `char::is_uppercase` const) - rust-lang#101407 (Remove duplicated test (superseeded by search-form-elements.goml)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101376