Skip to content

Remove util::unreachable #9312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Sep 19, 2013 · 6 comments · Fixed by #9320
Closed

Remove util::unreachable #9312

brson opened this issue Sep 19, 2013 · 6 comments · Fixed by #9320
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Sep 19, 2013

The macro is better.
@luisbg
Copy link
Contributor

luisbg commented Sep 19, 2013

This looks like a very interesting first bug to squash for me.
I'm volunteering for assignment.

@brson
Copy link
Contributor Author

brson commented Sep 19, 2013

@luisbg You've got it!

@chris-morgan
Copy link
Member

@luisbg Actually, I've already done this; I had just been waiting for the next snapshot to be made so that the macro could be used.

@chris-morgan
Copy link
Member

This is part of #8991.

@brson
Copy link
Contributor Author

brson commented Sep 19, 2013

Sorry @luisbg. My mistake.

@chris-morgan chris-morgan mentioned this issue Sep 19, 2013
Merged
@luisbg
Copy link
Contributor

luisbg commented Sep 19, 2013

No problem.

@brson if you see any other good first contribution bugs let me now. Still hunting for that first one.

bors added a commit that referenced this issue Sep 20, 2013
@bors
auto merge of #9320 : chris-morgan/rust/unreachable-macro-part-two-of…
e5fdc7d 
…-two-containing-the-destruction-of-the-unreachable-function, r=alexcrichton

This is the second of two parts of #8991, now possible as a new snapshot
has been made. (The first part implemented the unreachable!() macro; it
was #8992, 6b7b8f2.)

``std::util::unreachable()`` is removed summarily; any code which used
it should now use the ``unreachable!()`` macro.

Closes #9312.

Closes #8991.
@bors bors closed this as completed in e2807a4 Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace unreachable() calls with unreachable!(). chris-morgan/rust
3 participants
@brson @luisbg @chris-morgan