Skip to content

function parameter/return attributes are set incorrectly #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thestinger opened this issue Sep 10, 2013 · 0 comments
Closed

function parameter/return attributes are set incorrectly #9104

thestinger opened this issue Sep 10, 2013 · 0 comments
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

These should be set while declaring a function, not defining one. At the moment they are not ever applied to external calls.
@ghost ghost assigned thestinger Sep 10, 2013
thestinger added a commit that referenced this issue Sep 11, 2013
@thestinger
fix handling of function attributes
3f99540 
The `noalias` attributes were being set only on function definitions,
not on all declarations. This is harmless for `noalias`, but prevented
some optimization opportunities and is *not* harmless for other
attributes like `sret` with ABI implications.

Closes #9104
@thestinger thestinger removed their assignment Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thestinger