Skip to content

Make RenderOptions fields' type into newtype instead of boolean for clarity #87752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #113248
GuillaumeGomez opened this issue Aug 4, 2021 · 0 comments
Open
Tracked by #113248

Make RenderOptions fields' type into newtype instead of boolean for clarity #87752

GuillaumeGomez opened this issue Aug 4, 2021 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

The discussion happened there: #84176 (comment). Quoting @estebank:

I meant newtyping the bools for each field, so that someone doesn't accidentally sets generate_link_to_definition to true, when they meant to set show_type_layout, although with named fields this is less of a concern.
@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 4, 2021
@tgross35 tgross35 mentioned this issue Jul 1, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GuillaumeGomez