-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix span on unknown macro variable error #6691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
A-syntaxext
Area: Syntax extensions
P-low
Low priority
Comments
Reproduced 2013-07-25. Relative of #7970 perhaps? Nominating for production ready. For ease of future reproduction, here's the test. Note where the failure is pointing to, relative to where the actual error is (the use of
|
Accepted for production-ready |
P-low, not 1.0. |
This seems to have been fixed:
|
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Feb 11, 2021
… crate sources file to use. Fixes rust-lang#6691
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Feb 11, 2021
lintcheck: add a cmdline option --crates-toml <TOML PATH> to override crate sources file to use. Fixes rust-lang#6691 changelog: lintcheck: add --crates-toml cmdline option to override default crates.toml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
A-syntaxext
Area: Syntax extensions
P-low
Low priority
In #6686 I added an error, but the span is incorrect. Ideally it would cover the use of the unknown variable and not the
m
inmacro_rules!
.The text was updated successfully, but these errors were encountered: