Skip to content

Encode/decode meta_name_values with non-string values #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jul 6, 2011 · 6 comments
Closed

Encode/decode meta_name_values with non-string values #623

brson opened this issue Jul 6, 2011 · 6 comments
Labels
A-metadata Area: Crate metadata
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Jul 6, 2011

ast::meta_item supports any literal as a value but the crate metadata encoder and decoder only knows how to deal with string values. This currently just means that crate attributes with non-string literal values, e.g. #[revision = 100u], will be silently lost.
@ghost ghost assigned nikomatsakis Mar 15, 2012
@pnkfelix
Copy link
Member

Not critical for 0.6; de-milestoning

@catamorphism
Copy link
Contributor

Nominating for milestone 3, feature-complete.

@graydon
Copy link
Contributor

graydon commented May 30, 2013

accepted for feature-complete milestone

@catamorphism
Copy link
Contributor

Visiting for triage. Milestone still valid.

@huonw
Copy link
Member

huonw commented Sep 23, 2013

Triage: still a problem.

@catamorphism
Copy link
Contributor

1.0, but for now we'll probably fix the grammar to only allow strings

@brson brson mentioned this issue Oct 30, 2013
Closed
brson added a commit to brson/rust that referenced this issue Oct 30, 2013
@brson
syntax: Forbid non-string literals in meta items. rust-lang#623
6ef1ab9
@bors bors closed this as completed in 68bf48e Oct 31, 2013
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@bors
Auto merge of rust-lang#623 - equal-l2:unify-bsd-flags, r=alexcrichton
b88c8f5 
Unify some BSD flags

These BSD flags have common value in all OSes, so I've merged them into root `mod.rs`.
- `O_ACCMODE`
- `O_RDONLY`
- `O_WRONLY`
- `O_RDWR`
- `O_APPEND`
- `O_CREAT`
- `O_TRUNC`
- `O_EXCL`
- `O_SYNC`
- `O_NONBLOCK`
- `O_SHLOCK`
- `O_EXLOCK`
- `O_FSYNC`
- `O_NDELAY`
pdietl pushed a commit to pdietl/rust that referenced this issue Apr 23, 2020
@Centril
Merge pull request rust-lang#623 from phil-opp/patch-1
65673ee 
Link to "const functions" section from constant expressions list
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Investigate memory error from lstm (rust-lang#623)
d4fde49
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws @tedinski
Remove panic::Location::<'a>::caller from skippable functions (rust…
a665585 
…-lang#623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-metadata Area: Crate metadata
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

syntax: Forbid non-string literals in meta items. #623 brson/rust
6 participants
@graydon @brson @nikomatsakis @pnkfelix @catamorphism @huonw