Rustdoc doesn't allow to navigate to lines after 50000

[Riateche]

When I click on the [src] link of a function in the rendered documentation, if the function's line number is greater than 50000, the browser navigates to line 50000 instead of the proper location. I found the relevant code here:

rust/src/librustdoc/html/static/main.js

Line 165 in 3418d2f

to = Math.min(50000, parseInt(match[2] || match[1], 10));

What's the rationale behind this limitation? Can it be lifted?

[Torrencem]

Interestingly, it looks like if this limit were removed, the for loop here might be a problem. Then, maybe, someone could link to a url such as https://doc.rust-lang.org/src/.../something.rs.html#1-9007199254740992 which would make the page freeze up, since the loop won't exit early if the line doesn't exist. I don't know if this would be considered harmful, however.

The edit would simply be to change the line to to = parseInt(match[2] || match[1], 10);, obviously

[Riateche]

The freeze in that for loop can be avoided with something like this:

for (i = from; i <= to; ++i) {
    let element = document.getElementById(i);
    if (!element) { break; }
    addClass(element, "line-highlighted");
}

[GuillaumeGomez]

Wo, super strange old code as it seems. Good catch!