Skip to content

Replace some native module syntax with attributes #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jun 22, 2011 · 2 comments
Closed

Replace some native module syntax with attributes #547

brson opened this issue Jun 22, 2011 · 2 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 22, 2011

Native mod declarations have some optional syntax (abi, native name) which can be turned into attributes.
@ghost ghost assigned brson Jun 22, 2011
@lht lht mentioned this issue Nov 11, 2011
Closed
@lht lht mentioned this issue Nov 15, 2011
Closed
lht added a commit to lht/rust that referenced this issue Nov 16, 2011
@lht
Use attributes for native module ABI and link name
bf612bf 
This patch changes how to specify ABI and link name of a native module.

Before:
  native "cdecl" mod llvm = "rustllvm" {...}

After:
  #[abi = "cdecl"]
  #[link_name = "rustllvm"]
  native mod llvm {...}

The old optional syntax for ABI and link name is no longer supported.

Fixes issue rust-lang#547
brson pushed a commit that referenced this issue Nov 16, 2011
@lht @brson
Use attributes for native module ABI and link name
88f29aa 
This patch changes how to specify ABI and link name of a native module.

Before:
  native "cdecl" mod llvm = "rustllvm" {...}

After:
  #[abi = "cdecl"]
  #[link_name = "rustllvm"]
  native mod llvm {...}

The old optional syntax for ABI and link name is no longer supported.

Fixes issue #547
@brson
Copy link
Contributor Author

brson commented Dec 1, 2011

@lht - is this finished?

@lht
Copy link
Contributor

lht commented Dec 1, 2011

Yes, all done.

@brson brson closed this as completed Dec 1, 2011
kazcw pushed a commit to kazcw/rust that referenced this issue Oct 23, 2018
@gnzlbg @alexcrichton
Table lookup fixes (rust-lang#547)
51904cd 
* test table lookup intrinsics with negative indices

* provide table lookup intrinsics only on little endian targets
pdietl pushed a commit to pdietl/rust that referenced this issue Apr 23, 2020
@Centril
Merge pull request rust-lang#547 from ehuss/glossary-impls
7acdcad 
Add some terms to the glossary.
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Expose freeMemory flag to CAPI (rust-lang#547)
bcdc1f9
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws @tedinski
Re-enable artifacts via dashboard update (rust-lang#547)
ef9ce7e 
* Re-enable artifacts via dashboard update

* Proper parsing, main and docs

* Copy fixup
tgross35 pushed a commit to tgross35/rust that referenced this issue Jun 3, 2025
@Amanieu
Merge pull request rust-lang#547 from klensy/edition-up
56364d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lht @brson