Skip to content

Remove dec_weak_task_count and inc_weak_task_count from rust_kernel #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Feb 2, 2013 · 2 comments
Closed

Remove dec_weak_task_count and inc_weak_task_count from rust_kernel #4768

brson opened this issue Feb 2, 2013 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@brson
Copy link
Contributor

brson commented Feb 2, 2013

register_task/unregister_task and dec_weak_task_count/inc_weak_task_count do the same thing.

@luqmana
Copy link
Member

luqmana commented Feb 7, 2013

So, should register_task/unregister_task then be exposed in rust_builtin so it can be called from Rust?

@brson
Copy link
Contributor Author

brson commented Feb 7, 2013

@luqmana Yes, though I suggest renaming it, since it will no longer just be used for 'registering', nor does it strictly have anything to do with tasks or weak tasks from the kernel's perspective - this count is only for determining when to shutdown the runtime. Maybe inc_live_count for the method name and rust_inc_kernel_live_count for the builtin. It's not great either, but is less wed to implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants