-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Closed
Labels
A-concurrencyArea: ConcurrencyArea: ConcurrencyE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Description
This module is unsafe because the linenoise library is not threadsafe. Use core::private::global_data
to store a global std::sync::Mutex
and use that mutex to protect all the calls in rl
.
Then make all the functions safe: #3921
Metadata
Metadata
Assignees
Labels
A-concurrencyArea: ConcurrencyArea: ConcurrencyE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.