-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ICE with trait inheritance/generics #4208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There are at least two problems here. The first is that the order in which type parameters are specified appears to be significant. This test fails:
but if you switch the type parameter order on The second is some cross-crate issue with inheritance. |
My above example is a different problem, since it makes sin have a bound of |
@catamorphism (nag nag) |
This ICEs with a different error now, but still ICEs. |
Unfortunately, I got derailed and this won't be done for 0.6. De-milestoning. |
This compiles now. I'll check in the test case. |
So is this fixed? |
(bug triage) Huh, I wonder whether I checked in the test case. I'll look at that tomorrow. |
#9233 will close this. |
…ondet, r=<try> Enable Non-determinism of float operations in Miri and change std tests Links to [rust-lang#4208](rust-lang/miri#4208) and [rust-lang#3555](rust-lang/miri#3555) in Miri. Non-determinism of floating point operations was disabled in rust-lang#137594 because it breaks the tests and doc-tests in core/coretests and std. This PR: - enables the float non-determinism but with a lower relative error of 4ULP instead of 16ULP - changes tests that made incorrect assumptions about the operations not to make that assumption anymore (from `assert_eq!` to `assert_approx_eq!`. - changes the `assert_approx_eq!` macro to allow up to 1e-4 to make the tests pass TODO: - I didn't touch the doc tests because I do not know nearly enough to come near them :) - probably change the `assert_approx_eq` to use the same technique as Miri (i.e., using ULP instead of EPSILON) try-job: x86_64-gnu-aux
numeric.rs
main.rs
The text was updated successfully, but these errors were encountered: