Skip to content

grammar/README.md is outdated #41326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
est31 opened this issue Apr 15, 2017 · 5 comments
Closed

grammar/README.md is outdated #41326

est31 opened this issue Apr 15, 2017 · 5 comments
Assignees
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high High priority

Comments

@est31
Copy link
Member

est31 commented Apr 15, 2017

src/grammar/README.md is outdated. First, it still contains mentions of the legacy make system. Also, while make and make tidy technically might work, make check-build-lexer-verifier doesn't work at least since commit 9ab8090 and the claim that make tidy includes the check is wrong even longer (d3b050c).

It should be updated. Most likely the the checks have to be ported over to the new system as well.

@kennytm
Copy link
Member

kennytm commented Apr 18, 2017

make and make tidy still works with rustbuild (the latter calls x.py test src/tools/tidy).

@est31
Copy link
Member Author

est31 commented Apr 18, 2017

@kennytm still, make check-build-lexer-verifier does not work (probably) since commit 9ab8090 and the claim the lexer verifier is built during make tidy is wrong even longer, since commit d3b050c .

The file is simply outdated and should be updated.

@est31 est31 changed the title grammar/README.md still references make and make tidy grammar/README.md is outdated Apr 18, 2017
@est31
Copy link
Member Author

est31 commented Apr 18, 2017

I'll edit the description to fit the problems more closely.

@GuillaumeGomez GuillaumeGomez added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 25, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 27, 2017
@steveklabnik steveklabnik self-assigned this Aug 30, 2017
@steveklabnik steveklabnik added the P-high High priority label Aug 30, 2017
@steveklabnik
Copy link
Member

Grammar stuff is in the reference now; we should remove the stuff in-tree.

@est31
Copy link
Member Author

est31 commented Aug 30, 2017

In fact the file in question was removed by commit c3781e6 (PR #41705). There's still grammar stuff in tree but that should be tracked by a separate issue. Closing.

@est31 est31 closed this as completed Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high High priority
Projects
None yet
Development

No branches or pull requests

5 participants