Skip to content

Error message overlap #37075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alex-PK opened this issue Oct 10, 2016 · 3 comments
Closed

Error message overlap #37075

Alex-PK opened this issue Oct 10, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Alex-PK
Copy link

Alex-PK commented Oct 10, 2016

When I have few errors (probably only where there is just one) the "running" error messages and the (same) messages after "waiting for other jobs to finish" are overlapping. Here is an example:

errorerror: expected `,` or `>` after lifetime name, found `T`: expected `,` or `>` after lifetime name, found `T`

      --> --> src/lib.rs:266:36src/lib.rs:266:36

    ||

266266  | | impl<'a, 'b, T> ::std::ops::Add<'b impl<'a, 'b, T> ::std::ops::Add<'b T> for &'a ValueT
> for &'a Value
        | |                                                                       ^^

        ||

notenote: did you mean a single argument type &'a Type, or did you mean the comma-separated arguments 'a, Type?: did you mean a single argument type &'a Type, or did you mean the comma-separated arguments 'a, Type?

      --> --> src/lib.rs:266:33src/lib.rs:266:33

        ||

266266  | | impl<'a, 'b, T> ::std::ops::Add<impl<'a, 'b, T> ::std::ops::Add<'b T>'b T> for &'a Value for &'a Value

    | |                                                                 ^^^^^^^^^^



errorerror: aborting due to previous error: aborting due to previous error



Build failed, waiting for other jobs to finish...

If I run the same command again, the messages are overlapping in different ways.

It looks like 2 threads are printing at the same time.

This happens on rust 1.12 on Linux with the new error messages format, but also on older versions with the old format. If I remember correctly, I saw it on OSX too, but I can't check right now.

Sorry if this was already reported, but I couldn't find it in the issues list, as I don't know exactly what terms to use for the search.

@Stebalien
Copy link
Contributor

Stebalien commented Oct 11, 2016

See #32486 ("interleave" is the word you're looking for). But yes, this is really annoying.

@sanxiyn sanxiyn added the A-diagnostics Area: Messages for errors, warnings, and lints label Oct 29, 2016
@steveklabnik steveklabnik added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2017
@Mark-Simulacrum
Copy link
Member

So I personally have never seen this. It's possible this is because I rarely see errors from two separate rustc's running in parallel; @alexcrichton you closed #32486 as "implemented" -- do you agree that we should close this as well?

@alexcrichton
Copy link
Member

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants