Skip to content

Track dependency edges from the tcx fulfillment cache #30741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikomatsakis opened this issue Jan 6, 2016 · 0 comments
Closed

Track dependency edges from the tcx fulfillment cache #30741

nikomatsakis opened this issue Jan 6, 2016 · 0 comments
Assignees
@nikomatsakis
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

The fulfillment cache in the tcx is not tracked and can lead to incorrect dependencies. This is demonstrated in the test case dep-graph-trait-impl.rs
@nikomatsakis nikomatsakis self-assigned this Jan 6, 2016
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-incr-comp Area: Incremental compilation labels Jan 6, 2016
@nikomatsakis nikomatsakis mentioned this issue Jan 21, 2016
Merged
bors added a commit that referenced this issue Jan 22, 2016
@bors
Auto merge of #31087 - nikomatsakis:incr-comp-fulfillment-cache, r=ar…
8f36038 
…ielb1

This is a fix for #30741. It simplifies dep-graph tracking for trait matching. I was experimenting with having a greater resolution here, but decided to pare back to just have one dep node for "trait resolutions on trait `Foo`", which means that adding an impl to the trait `Foo` will invalidate all fns that had to do any trait matching at all on `Foo`. This seems like a reasonable starting place.

Independently, I realized I had neglected to record a dependency from trans on typeck -- this is obviously needed, since trans consumes a bunch of data structures that typeck produces (but which are not currently individually tracked) -- and because trans assumes that typeck has been done. Eventually those are going to go away and be replaced with MIR, which will be tracked, so this edge would presumably be derived automatically then, but it's an obvious enough thing to want for now.

r? @arielb1

cc @michaelwoerister -- this might indirectly fix the problem you observed with the trans cache, though it'd be nice to try and craft an independent test case for that.
@bors bors closed this as completed in 0bdefd7 Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikomatsakis nikomatsakis

Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikomatsakis