Skip to content

Beautiful printing for rustc --explain command #24771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GuillaumeGomez opened this issue Apr 24, 2015 · 7 comments
Closed

Beautiful printing for rustc --explain command #24771

GuillaumeGomez opened this issue Apr 24, 2015 · 7 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@GuillaumeGomez
Copy link
Member

I open this issue to allow people to follow this feature status and I'd also like to do it myself if no one is against it.

This issue was "proposed" in #24523.

@tbelaire
Copy link
Contributor

So, I think it'd look best with the markdown rule of blank line + 4 space indent denotes a code block, same as ``` does, and that is a cleaner fallback when printing it to the terminal I feel. Does that make sense?

@GuillaumeGomez
Copy link
Member Author

You mean writing error explanation like this:

blabla
blabla

`` `
    code
    code
`` `

blabla

?

@tbelaire
Copy link
Contributor

No, check it out, this is a code block

this is a code block.

Source:

No, check it out, this is a code block

    this is a code block.

@tbelaire
Copy link
Contributor

Here's the spec for it: http://daringfireball.net/projects/markdown/syntax#precode

Technically, the ``` blocks are an extension to markdown, though they are pretty nice. It's easier to add in a plaintext editor, though the indent is easier in vim.

@steveklabnik steveklabnik added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 30, 2015
@steveklabnik
Copy link
Member

Triage: I am not 100% sure what exactly is being proposed here; @jonathandturner has been working on a new error formatting RFC that may significantly modify --explain's output, though.

@Mark-Simulacrum
Copy link
Member

This does not seem to be a concrete issue, so I'm not sure that we should keep it open. @GuillaumeGomez Could you maybe update the description with at least one or two things that we should do?

@GuillaumeGomez
Copy link
Member Author

I think there's no point keeping it open now. People are working on this and it's on the roadmap iirc. Let's close it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

4 participants