Skip to content

test/run-pass/issue-2316.rs fails if ran without a full make first #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marijnh opened this issue May 8, 2012 · 0 comments
Closed

test/run-pass/issue-2316.rs fails if ran without a full make first #2368

marijnh opened this issue May 8, 2012 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone

Comments

@marijnh
Copy link
Contributor

marijnh commented May 8, 2012

The tests no longer depend on librustc. This one shouldn't either. It is easy to reproduce the situation that led to the bug in a module inside the test program, there's no need to reach into the internals of librustc (in fact, that's very fragile, and might even result in the test passing when the bug resurfaces, since the imports in rustc/middle/ty.rs can change at any time).

@ghost ghost assigned catamorphism May 8, 2012
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
Make "./miri {build,run,test}" use debug assertions but "./miri install" not

This makes `./miri run`/`./miri test` use the full set of debug assertions (including the rather expensive ones that check consistency of the Stacked Borrows cache), but `./miri install` installs a Miri *without* those debug assertions.

That's the same behavior as cargo, and helps catch Miri bugs with the test suite while making installed Miri usable for larger runs.
tshepang added a commit to tshepang/rust that referenced this issue May 1, 2025
Adds 'with' to the bootstrapping docs to help clarify how to build a new compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

2 participants