Skip to content

IoError is kind of archaic #16524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bluss opened this issue Aug 15, 2014 · 5 comments
Closed

IoError is kind of archaic #16524

bluss opened this issue Aug 15, 2014 · 5 comments

Comments

@bluss
Copy link
Member

bluss commented Aug 15, 2014

The documentation for IoError still says # FIXME Is something like this sufficient? It's kind of archaic.

This is an issue to track this untagged FIXME. It should be addressed or the documentation should be updated -- I'm reporting this due to a user question about IoError on IRC.
@aturon
Copy link
Member

aturon commented Aug 15, 2014

cc me

@reem
Copy link
Contributor

reem commented Aug 15, 2014

cc me

@brson
Copy link
Contributor

brson commented Aug 15, 2014

I may have written the FIXME, and probably I was thinking that it was 'archaic' to bubble up unixy I/O error codes with an ancient legacy and loose mapping to non-unixes.

In hindsight I'm no longer too concerned about that. The names have been mostly well-rustified, and they are abstracted across platform reasonably well by virtue of the I/O stack being implemented cross-platform, and libuv already having done much of the error-unifying work for us.

Another concern is that the list of possible errors is static.

The naming of the variants should be scrutinized.

@reem
Copy link
Contributor

reem commented Aug 16, 2014

Relevant: rust-lang/rfcs#201

@alexcrichton
Copy link
Member

This is quite an old issue and io::Error is now stable, so closing

matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Feb 11, 2024
@bors
Auto merge of rust-lang#16524 - evertedsphere:swann/trait-bound-dyn, …
0878cde 
…r=Veykril

minor: test that flip_trait_bound works with trait objects

Closes rust-lang/rust-analyzer#16522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @brson @aturon @bluss @reem