Re-exports of hidden items are inconsistent

[lolbinarycat]

example

If an item in a hidden module is reexported, it will be automatically inlined, but if the item itself is hidden (and in a non-hidden module), it will show as a regular reexport, with a link to a normally hidden page.

This also makes the item not show in the "all items" list, despite being publicly reachable.

[xizheyin]

Has anyone started this issue already? Maybe I could try it. @lolbinarycat

[lolbinarycat]

@xizheyin do you have any experience working on rustdoc? this is not a trivial issue.

[xizheyin]

I have previously used librustdoc to create a small tool,but I only utilized a part of theclean/module. I took a look at the rest of librustdoc's code and got a general understanding of its structure.I'm not sure if I underestimated the difficulty.

[lolbinarycat]

I imagine it's an issue with the pass that removes doc(hidden) items. It might require a bit of refactoring to solve this issue in a performant way.

[xizheyin]

Ok, I'll take a deeper look. If the bug isn't particularly urgent.

[xizheyin]

@rustbot claim

[xizheyin]

I have tried to inline hidden_self_reexport as the discussion. Is that right? @lolbinarycat

Update:
It conflicts with the existing logic. What would be a better solution to this issue? Hide them all?

[lolbinarycat]

@xizheyin i don't have the final say on what the "right" way to fix it is, but if it was up to me, all 4 functions would be inlined.

figuring out how to do this efficiently without introducing new bugs is the hard part.

[xizheyin]

@xizheyin i don't have the final say on what the "right" way to fix it is, but if it was up to me, all 4 functions would be inlined.

yeah,that is what i have done. But it may conflict with the existing testcase.