Skip to content

config.example.toml: use vendor directory by default when compiling from https://static.rust-lang.org/dist/rustc-1.x.y-src.tar.xz #133664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dilyanpalauzov opened this issue Nov 30, 2024 · 3 comments
Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@dilyanpalauzov
Copy link

The file https://static.rust-lang.org/dist/rustc-1.83.0-src.tar.xz — config.example.toml contains

[build]
# Indicate whether the vendored sources are used for Rust dependencies or not.
#
# Vendoring requires additional setup. We recommend using the pre-generated source tarballs if you
# want to use vendoring. See
# https://forge.rust-lang.org/infra/other-installation-methods.html#source-code.
#vendor = false

[dist]
# Whether to vendor dependencies for the dist tarball.
#vendor = if "is a tarball source" || "is a git repository" { true } else { false }

My reading is that the vendor/ directory from rustc-1.83.0-src.tar.xz by default is not used. By default, this directory should be used, when compiling from the .tar file.

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 30, 2024
@dilyanpalauzov
Copy link
Author

… or if the default is false then do not include the vendor/ directory in the stable, distributed tarball.

@dilyanpalauzov dilyanpalauzov changed the title config.example.toml: use vendor directory when compiling from https://static.rust-lang.org/dist/rustc-1.x.y-src.tar.xz config.example.toml: use vendor directory by default when compiling from https://static.rust-lang.org/dist/rustc-1.x.y-src.tar.xz Nov 30, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-discussion Category: Discussion or questions that doesn't represent real issues. A-bootstrap-config Area: bootstrap `config.toml` and the config system C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. C-discussion Category: Discussion or questions that doesn't represent real issues. labels Dec 1, 2024
@bjorn3
Copy link
Member

bjorn3 commented Dec 1, 2024

Omitting the vendor directory would make it impossible to do a vendored build when you have an offline build environment. There is something to be said for using vendoring by default when building from a tarball though, although you did still need some manual configuration to set a bootstrap compiler when you want to do an offline build anyway.

@onur-ozkan
Copy link
Member

#133853 should handle this. It will take effect in the next nightly release after the merge, but it will take some time for it to reach into the stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants